Changeset 48937 for trunk/tests/phpunit/tests/post/getPageChildren.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/post/getPageChildren.php (modified) (2 diffs)

trunk/tests/phpunit/tests/post/getPageChildren.php

@@ -75 +75 @@
         $expected = array( 100, 101, 103, 102, 106, 107, 108, 105 );
         $actual   = get_page_children( 0, $this->pages );
-        $this->assertEquals( $expected, wp_list_pluck( $actual, 'ID' ) );
+        $this->assertSame( $expected, wp_list_pluck( $actual, 'ID' ) );
     }
 
@@ -81 +81 @@
         $expected = array( 106, 107, 108 );
         $actual   = get_page_children( 102, $this->pages );
-        $this->assertEquals( $expected, wp_list_pluck( $actual, 'ID' ) );
+        $this->assertSame( $expected, wp_list_pluck( $actual, 'ID' ) );
     }
 
     public function test_page_id_that_is_a_leaf_should_return_empty_array() {
         $actual = get_page_children( 103, $this->pages );
-        $this->assertEquals( array(), $actual );
+        $this->assertSame( array(), $actual );
     }
 
     public function test_nonzero_page_id_not_matching_any_actual_post_id_should_return_empty_array() {
         $actual = get_page_children( 200, $this->pages );
-        $this->assertEquals( array(), $actual );
+        $this->assertSame( array(), $actual );
     }
 }