Changeset 48937 for trunk/tests/phpunit/tests/post/wpUniquePostSlug.php

Timestamp:

09/02/2020 12:35:36 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/post/wpUniquePostSlug.php (modified) (13 diffs)

trunk/tests/phpunit/tests/post/wpUniquePostSlug.php

@@ -37 +37 @@
 
             $post = get_post( $id );
-            $this->assertEquals( $outputs[ $k ], urldecode( $post->post_name ) );
+            $this->assertSame( $outputs[ $k ], urldecode( $post->post_name ) );
         }
     }
@@ -57 +57 @@
         $two               = self::factory()->post->create( $args );
 
-        $this->assertEquals( 'some-slug', get_post( $one )->post_name );
-        $this->assertEquals( 'some-slug', get_post( $two )->post_name );
-
-        $this->assertEquals( 'some-other-slug', wp_unique_post_slug( 'some-other-slug', $one, 'publish', 'post-type-1', 0 ) );
-        $this->assertEquals( 'some-other-slug', wp_unique_post_slug( 'some-other-slug', $one, 'publish', 'post-type-2', 0 ) );
+        $this->assertSame( 'some-slug', get_post( $one )->post_name );
+        $this->assertSame( 'some-slug', get_post( $two )->post_name );
+
+        $this->assertSame( 'some-other-slug', wp_unique_post_slug( 'some-other-slug', $one, 'publish', 'post-type-1', 0 ) );
+        $this->assertSame( 'some-other-slug', wp_unique_post_slug( 'some-other-slug', $one, 'publish', 'post-type-2', 0 ) );
 
         _unregister_post_type( 'post-type-1' );
@@ -82 +82 @@
         $two               = self::factory()->post->create( $args );
 
-        $this->assertEquals( 'some-slug', get_post( $one )->post_name );
-        $this->assertEquals( 'some-slug-2', get_post( $two )->post_name );
-
-        $this->assertEquals( 'some-slug-3', wp_unique_post_slug( 'some-slug', 0, 'publish', 'post-type-1', 0 ) );
+        $this->assertSame( 'some-slug', get_post( $one )->post_name );
+        $this->assertSame( 'some-slug-2', get_post( $two )->post_name );
+
+        $this->assertSame( 'some-slug-3', wp_unique_post_slug( 'some-slug', 0, 'publish', 'post-type-1', 0 ) );
 
         _unregister_post_type( 'post-type-1' );
@@ -118 +118 @@
         $two  = self::factory()->post->create( $args );
 
-        $this->assertEquals( 'some-slug', get_post( $one )->post_name );
-        $this->assertEquals( 'image', get_post( $attachment )->post_name );
-        $this->assertEquals( 'image-2', get_post( $two )->post_name );
+        $this->assertSame( 'some-slug', get_post( $one )->post_name );
+        $this->assertSame( 'image', get_post( $attachment )->post_name );
+        $this->assertSame( 'image-2', get_post( $two )->post_name );
 
         // 'image' can be a child of image-2.
-        $this->assertEquals( 'image', wp_unique_post_slug( 'image', 0, 'publish', 'post-type-1', $two ) );
+        $this->assertSame( 'image', wp_unique_post_slug( 'image', 0, 'publish', 'post-type-1', $two ) );
 
         _unregister_post_type( 'post-type-1' );
@@ -191 +191 @@
 
         $found = wp_unique_post_slug( '2015', $p, 'publish', 'post', 0 );
-        $this->assertEquals( '2015-2', $found );
+        $this->assertSame( '2015-2', $found );
     }
 
@@ -209 +209 @@
 
         $found = wp_unique_post_slug( '2015', $p, 'publish', 'post', 0 );
-        $this->assertEquals( '2015-2', $found );
+        $this->assertSame( '2015-2', $found );
     }
 
@@ -226 +226 @@
 
         $found = wp_unique_post_slug( '2015', $p, 'publish', 'post', 0 );
-        $this->assertEquals( '2015', $found );
+        $this->assertSame( '2015', $found );
     }
 
@@ -243 +243 @@
 
         $found = wp_unique_post_slug( '11', $p, 'publish', 'post', 0 );
-        $this->assertEquals( '11-2', $found );
+        $this->assertSame( '11-2', $found );
     }
 
@@ -260 +260 @@
 
         $found = wp_unique_post_slug( '11', $p, 'publish', 'post', 0 );
-        $this->assertEquals( '11', $found );
+        $this->assertSame( '11', $found );
     }
 
@@ -277 +277 @@
 
         $found = wp_unique_post_slug( '13', $p, 'publish', 'post', 0 );
-        $this->assertEquals( '13', $found );
+        $this->assertSame( '13', $found );
     }
 
@@ -294 +294 @@
 
         $found = wp_unique_post_slug( '30', $p, 'publish', 'post', 0 );
-        $this->assertEquals( '30-2', $found );
+        $this->assertSame( '30-2', $found );
     }
 
@@ -311 +311 @@
 
         $found = wp_unique_post_slug( '30', $p, 'publish', 'post', 0 );
-        $this->assertEquals( '30', $found );
+        $this->assertSame( '30', $found );
     }
 
@@ -328 +328 @@
 
         $found = wp_unique_post_slug( '32', $p, 'publish', 'post', 0 );
-        $this->assertEquals( '32', $found );
+        $this->assertSame( '32', $found );
     }