Changeset 48937 for trunk/tests/phpunit/tests/query/dateQuery.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/query/dateQuery.php (modified) (27 diffs)

trunk/tests/phpunit/tests/query/dateQuery.php

@@ -97 +97 @@
         );
 
-        $this->assertEquals( array( $p1, $p2 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1, $p2 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -142 +142 @@
         );
 
-        $this->assertEquals( array( $p2 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p2 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -160 +160 @@
         );
 
-        $this->assertEquals( array( $p3 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p3 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -179 +179 @@
         );
 
-        $this->assertEquals( array( $p2, $p3 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p2, $p3 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -208 +208 @@
         );
 
-        $this->assertEquals( array( $p2, $p3, $p4 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p2, $p3, $p4 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -248 +248 @@
         );
 
-        $this->assertEquals( array( $p2 ), $before_posts );
-        $this->assertEquals( array( $p1 ), $after_posts );
+        $this->assertSame( array( $p2 ), $before_posts );
+        $this->assertSame( array( $p1 ), $after_posts );
     }
 
@@ -332 +332 @@
         );
 
-        $this->assertEquals( array( $p2 ), $before_posts );
-        $this->assertEquals( array( $p1 ), $after_posts );
+        $this->assertSame( array( $p2 ), $before_posts );
+        $this->assertSame( array( $p1 ), $after_posts );
     }
 
@@ -416 +416 @@
         );
 
-        $this->assertEquals( array( $p2 ), $before_posts );
-        $this->assertEquals( array( $p1 ), $after_posts );
+        $this->assertSame( array( $p2 ), $before_posts );
+        $this->assertSame( array( $p1 ), $after_posts );
     }
 
@@ -500 +500 @@
         );
 
-        $this->assertEquals( array( $p2 ), $before_posts );
-        $this->assertEquals( array( $p1 ), $after_posts );
+        $this->assertSame( array( $p2 ), $before_posts );
+        $this->assertSame( array( $p1 ), $after_posts );
     }
 
@@ -584 +584 @@
         );
 
-        $this->assertEquals( array( $p2 ), $before_posts );
-        $this->assertEquals( array( $p1 ), $after_posts );
+        $this->assertSame( array( $p2 ), $before_posts );
+        $this->assertSame( array( $p1 ), $after_posts );
     }
 
@@ -668 +668 @@
         );
 
-        $this->assertEquals( array( $p1, $p2 ), $before_posts );
+        $this->assertSame( array( $p1, $p2 ), $before_posts );
     }
 
@@ -684 +684 @@
         );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -700 +700 @@
         );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -716 +716 @@
         );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -733 +733 @@
         );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -750 +750 @@
         );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -770 +770 @@
         );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -787 +787 @@
         );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -807 +807 @@
         );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -824 +824 @@
         );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -841 +841 @@
         );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -890 +890 @@
         );
 
-        $this->assertEquals( array( $p1, $p3 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1, $p3 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -911 +911 @@
         );
 
-        $this->assertEquals( array( $p2, $p3, $p4 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p2, $p3, $p4 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -930 +930 @@
         );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
 
         $this->assertContains( "MONTH( $wpdb->posts.post_date ) = 5", $this->q->request );
@@ -952 +952 @@
         );
 
-        $this->assertEquals( array( $p2 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p2 ), wp_list_pluck( $posts, 'ID' ) );
 
         $this->assertContains( "WEEK( $wpdb->posts.post_date, 1 ) = 43", $this->q->request );
@@ -993 +993 @@
         _unregister_taxonomy( 'foo' );
 
-        $this->assertEquals( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p1 ), wp_list_pluck( $posts, 'ID' ) );
     }
 
@@ -1024 +1024 @@
         );
 
-        $this->assertEquals( array( $p2, $p3 ), wp_list_pluck( $posts, 'ID' ) );
+        $this->assertSame( array( $p2, $p3 ), wp_list_pluck( $posts, 'ID' ) );
     }