Changeset 48937 for trunk/tests/phpunit/tests/query/taxQuery.php

Timestamp:

09/02/2020 12:35:36 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/query/taxQuery.php (modified) (26 diffs)

trunk/tests/phpunit/tests/query/taxQuery.php

@@ -34 +34 @@
         );
 
-        $this->assertEquals( array( $p1 ), $q->posts );
+        $this->assertSame( array( $p1 ), $q->posts );
     }
 
@@ -65 +65 @@
         );
 
-        $this->assertEquals( array( $p1 ), $q->posts );
+        $this->assertSame( array( $p1 ), $q->posts );
     }
 
@@ -99 +99 @@
         );
 
-        $this->assertEquals( array( $p1 ), $q->posts );
+        $this->assertSame( array( $p1 ), $q->posts );
     }
 
@@ -130 +130 @@
         );
 
-        $this->assertEquals( array( $p1 ), $q->posts );
+        $this->assertSame( array( $p1 ), $q->posts );
     }
 
@@ -161 +161 @@
         );
 
-        $this->assertEquals( array( $p1 ), $q->posts );
+        $this->assertSame( array( $p1 ), $q->posts );
     }
 
@@ -193 +193 @@
         );
 
-        $this->assertEquals( array( $p1 ), $q->posts );
+        $this->assertSame( array( $p1 ), $q->posts );
     }
 
@@ -225 +225 @@
         );
 
-        $this->assertEquals( array( $p2 ), $q->posts );
+        $this->assertSame( array( $p2 ), $q->posts );
     }
 
@@ -257 +257 @@
         );
 
-        $this->assertEquals( array( $p1 ), $q->posts );
+        $this->assertSame( array( $p1 ), $q->posts );
     }
 
@@ -339 +339 @@
         );
 
-        $this->assertEquals( array( $p3 ), $q->posts );
+        $this->assertSame( array( $p3 ), $q->posts );
     }
 
@@ -390 +390 @@
         );
 
-        $this->assertEquals( array( $p3 ), $q->posts );
+        $this->assertSame( array( $p3 ), $q->posts );
     }
 
@@ -431 +431 @@
         );
 
-        $this->assertEquals( array( $p2 ), $q->posts );
+        $this->assertSame( array( $p2 ), $q->posts );
     }
 
@@ -660 +660 @@
         );
 
-        $this->assertEquals( array( $p2 ), $q->posts );
+        $this->assertSame( array( $p2 ), $q->posts );
     }
 
@@ -1026 +1026 @@
 
         $posts = $query->get_posts();
-        $this->assertEquals( 0, count( $posts ) );
+        $this->assertSame( 0, count( $posts ) );
     }
 
@@ -1061 +1061 @@
 
         $posts = $query->get_posts();
-        $this->assertEquals( 0, count( $posts ) );
+        $this->assertSame( 0, count( $posts ) );
     }
 
@@ -1113 +1113 @@
         );
 
-        $this->assertEquals( 4, count( $posts ) );
+        $this->assertSame( 4, count( $posts ) );
 
         $posts = get_posts(
@@ -1131 +1131 @@
         );
 
-        $this->assertEquals( 1, count( $posts ) );
+        $this->assertSame( 1, count( $posts ) );
 
         $posts = get_posts(
@@ -1148 +1148 @@
         );
 
-        $this->assertEquals( 3, count( $posts ) );
+        $this->assertSame( 3, count( $posts ) );
 
         $posts = get_posts(
@@ -1166 +1166 @@
         );
 
-        $this->assertEquals( 1, count( $posts ) );
+        $this->assertSame( 1, count( $posts ) );
 
         $posts = get_posts(
@@ -1183 +1183 @@
         );
 
-        $this->assertEquals( 1, count( $posts ) );
+        $this->assertSame( 1, count( $posts ) );
 
         $posts = get_posts(
@@ -1201 +1201 @@
         );
 
-        $this->assertEquals( 1, count( $posts ) );
+        $this->assertSame( 1, count( $posts ) );
     }
 
@@ -1241 +1241 @@
         );
 
-        $this->assertEquals( array( $image_id ), $posts );
+        $this->assertSame( array( $image_id ), $posts );
     }
 
@@ -1346 +1346 @@
         );
 
-        $this->assertEquals( array( $posts[0], $posts[1], $posts[2] ), $results1, 'Relation: OR; Operator: AND' );
+        $this->assertSame( array( $posts[0], $posts[1], $posts[2] ), $results1, 'Relation: OR; Operator: AND' );
 
         $results2 = $q->query(
@@ -1373 +1373 @@
         );
 
-        $this->assertEquals( array( $posts[0], $posts[3] ), $results2, 'Relation: AND; Operator: IN' );
+        $this->assertSame( array( $posts[0], $posts[3] ), $results2, 'Relation: AND; Operator: IN' );
     }
 
@@ -1494 +1494 @@
         );
 
-        $this->assertEquals( $t, $q->get( 'term_id' ) );
+        $this->assertSame( $t, $q->get( 'term_id' ) );
 
         _unregister_taxonomy( 'foo' );
@@ -1540 +1540 @@
         );
 
-        $this->assertEquals( $c, $q->get( 'cat' ) );
-        $this->assertEquals( 'bar', $q->get( 'category_name' ) );
+        $this->assertSame( $c, $q->get( 'cat' ) );
+        $this->assertSame( 'bar', $q->get( 'category_name' ) );
 
         _unregister_taxonomy( 'foo' );
@@ -1587 +1587 @@
         );
 
-        $this->assertEquals( $tag, $q->get( 'tag_id' ) );
+        $this->assertSame( $tag, $q->get( 'tag_id' ) );
 
         _unregister_taxonomy( 'foo' );