Changeset 48937 for trunk/tests/phpunit/tests/rest-api/rest-block-renderer-controller.php

Timestamp:

09/02/2020 12:35:36 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/rest-api/rest-block-renderer-controller.php (modified) (10 diffs)

trunk/tests/phpunit/tests/rest-api/rest-block-renderer-controller.php

@@ -336 +336 @@
         );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertEquals( 400, $response->get_status() );
+        $this->assertSame( 400, $response->get_status() );
     }
 
@@ -357 +357 @@
         );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertEquals( 400, $response->get_status() );
+        $this->assertSame( 400, $response->get_status() );
     }
 
@@ -382 +382 @@
         $request->set_param( 'attributes', array() );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertEquals( 200, $response->get_status() );
+        $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
 
-        $this->assertEquals( $defaults, json_decode( $data['rendered'], true ) );
+        $this->assertSame( $defaults, json_decode( $data['rendered'], true ) );
         $this->assertEquals(
             json_decode( $block_type->render( $defaults ) ),
@@ -417 +417 @@
         $request->set_param( 'attributes', $attributes );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertEquals( 200, $response->get_status() );
+        $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
 
-        $this->assertEquals( $expected_attributes, json_decode( $data['rendered'], true ) );
+        $this->assertSame( $expected_attributes, json_decode( $data['rendered'], true ) );
         $this->assertEquals(
             json_decode( $block_type->render( $attributes ), true ),
@@ -452 +452 @@
         $request->set_param( 'attributes', $attributes );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertEquals( 200, $response->get_status() );
+        $this->assertSame( 200, $response->get_status() );
 
         $data = $response->get_data();
-        $this->assertEquals( '<p>Alternate content.</p>', $data['rendered'] );
+        $this->assertSame( '<p>Alternate content.</p>', $data['rendered'] );
 
         remove_filter( 'pre_render_block', $pre_render_filter );
@@ -475 +475 @@
         $response = rest_get_server()->dispatch( $request );
 
-        $this->assertEquals( 200, $response->get_status() );
+        $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
 
@@ -484 +484 @@
         $response = rest_get_server()->dispatch( $request );
 
-        $this->assertEquals( 200, $response->get_status() );
+        $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
 
-        $this->assertEquals( $expected_title, $data['rendered'] );
+        $this->assertSame( $expected_title, $data['rendered'] );
     }
 
@@ -505 +505 @@
         $response = rest_get_server()->dispatch( $request );
 
-        $this->assertEquals( 200, $response->get_status() );
+        $this->assertSame( 200, $response->get_status() );
         $this->assertContains( $string_attribute, $response->get_data()['rendered'] );
     }
@@ -579 +579 @@
         $request->set_param( 'attributes', $attributes );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertEquals( 200, $response->get_status() );
+        $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
 
@@ -602 +602 @@
             array_keys( $data['endpoints'][0]['args'] )
         );
-        $this->assertEquals( 'object', $data['endpoints'][0]['args']['attributes']['type'] );
+        $this->assertSame( 'object', $data['endpoints'][0]['args']['attributes']['type'] );
 
         $this->assertArrayHasKey( 'schema', $data );
-        $this->assertEquals( 'rendered-block', $data['schema']['title'] );
-        $this->assertEquals( 'object', $data['schema']['type'] );
+        $this->assertSame( 'rendered-block', $data['schema']['title'] );
+        $this->assertSame( 'object', $data['schema']['type'] );
         $this->arrayHasKey( 'rendered', $data['schema']['properties'] );
         $this->arrayHasKey( 'string', $data['schema']['properties']['rendered']['type'] );
-        $this->assertEquals( array( 'edit' ), $data['schema']['properties']['rendered']['context'] );
+        $this->assertSame( array( 'edit' ), $data['schema']['properties']['rendered']['context'] );
     }