Changeset 48937 for trunk/tests/phpunit/tests/taxonomy.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/taxonomy.php (modified) (13 diffs)

trunk/tests/phpunit/tests/taxonomy.php

@@ -6 +6 @@
 class Tests_Taxonomy extends WP_UnitTestCase {
     function test_get_post_taxonomies() {
-        $this->assertEquals( array( 'category', 'post_tag', 'post_format' ), get_object_taxonomies( 'post' ) );
+        $this->assertSame( array( 'category', 'post_tag', 'post_format' ), get_object_taxonomies( 'post' ) );
     }
 
     function test_get_link_taxonomies() {
-        $this->assertEquals( array( 'link_category' ), get_object_taxonomies( 'link' ) );
+        $this->assertSame( array( 'link_category' ), get_object_taxonomies( 'link' ) );
     }
 
@@ -18 +18 @@
     function test_get_unknown_taxonomies() {
         // Taxonomies for an unknown object type.
-        $this->assertEquals( array(), get_object_taxonomies( rand_str() ) );
-        $this->assertEquals( array(), get_object_taxonomies( '' ) );
-        $this->assertEquals( array(), get_object_taxonomies( 0 ) );
-        $this->assertEquals( array(), get_object_taxonomies( null ) );
+        $this->assertSame( array(), get_object_taxonomies( rand_str() ) );
+        $this->assertSame( array(), get_object_taxonomies( '' ) );
+        $this->assertSame( array(), get_object_taxonomies( 0 ) );
+        $this->assertSame( array(), get_object_taxonomies( null ) );
     }
 
@@ -30 +30 @@
             $this->assertTrue( is_object( $tax ) );
             $this->assertTrue( is_array( $tax->object_type ) );
-            $this->assertEquals( array( 'post' ), $tax->object_type );
+            $this->assertSame( array( 'post' ), $tax->object_type );
         }
     }
@@ -39 +39 @@
         $taxes = get_the_taxonomies( $post_id );
         $this->assertNotEmpty( $taxes );
-        $this->assertEquals( array( 'category' ), array_keys( $taxes ) );
+        $this->assertSame( array( 'category' ), array_keys( $taxes ) );
 
         $id = self::factory()->tag->create();
@@ -47 +47 @@
         $this->assertNotEmpty( $taxes );
         $this->assertCount( 2, $taxes );
-        $this->assertEquals( array( 'category', 'post_tag' ), array_keys( $taxes ) );
+        $this->assertSame( array( 'category', 'post_tag' ), array_keys( $taxes ) );
     }
 
@@ -57 +57 @@
 
         $taxes = get_the_taxonomies( $post_id, array( 'term_template' => '%2$s' ) );
-        $this->assertEquals( 'Categories: Uncategorized.', $taxes['category'] );
+        $this->assertSame( 'Categories: Uncategorized.', $taxes['category'] );
 
         $taxes = get_the_taxonomies( $post_id, array( 'term_template' => '<span class="foo"><a href="%1$s">%2$s</a></span>' ) );
         $link  = get_category_link( 1 );
-        $this->assertEquals( 'Categories: <span class="foo"><a href="' . $link . '">Uncategorized</a></span>.', $taxes['category'] );
+        $this->assertSame( 'Categories: <span class="foo"><a href="' . $link . '">Uncategorized</a></span>.', $taxes['category'] );
     }
 
@@ -91 +91 @@
             )
         );
-        $this->assertEquals( 'Categories: Uncategorized.', $output );
+        $this->assertSame( 'Categories: Uncategorized.', $output );
 
         $output = get_echo(
@@ -103 +103 @@
         );
         $link   = get_category_link( 1 );
-        $this->assertEquals( 'Categories: <span class="foo"><a href="' . $link . '">Uncategorized</a></span>.', $output );
+        $this->assertSame( 'Categories: <span class="foo"><a href="' . $link . '">Uncategorized</a></span>.', $output );
     }
 
@@ -112 +112 @@
             $this->assertTrue( is_object( $tax ) );
             $this->assertTrue( is_array( $tax->object_type ) );
-            $this->assertEquals( array( 'link' ), $tax->object_type );
+            $this->assertSame( array( 'link' ), $tax->object_type );
         }
     }
@@ -286 +286 @@
         $terms = get_objects_in_term( 1, 'invalid_taxonomy' );
         $this->assertInstanceOf( 'WP_Error', $terms );
-        $this->assertEquals( 'invalid_taxonomy', $terms->get_error_code() );
+        $this->assertSame( 'invalid_taxonomy', $terms->get_error_code() );
     }
 
     public function test_get_objects_in_term_should_return_empty_array() {
-        $this->assertEquals( array(), get_objects_in_term( 1, 'post_tag' ) );
+        $this->assertSame( array(), get_objects_in_term( 1, 'post_tag' ) );
     }
 
@@ -430 +430 @@
             'cat_name' => 'Updated Name',
         );
-        $this->assertEquals( 1, wp_insert_category( $cat ) );
+        $this->assertSame( 1, wp_insert_category( $cat ) );
     }
 
@@ -448 +448 @@
             'cat_name' => 'Error',
         );
-        $this->assertEquals( 0, wp_insert_category( $cat, false ) );
+        $this->assertSame( 0, wp_insert_category( $cat, false ) );
     }
 
@@ -964 +964 @@
         $problematic_term = current( wp_list_pluck( $terms_obj, 'name' ) );
 
-        $this->assertEquals( $problematic_term, $term_name );
+        $this->assertSame( $problematic_term, $term_name );
     }