Changeset 48937 for trunk/tests/phpunit/tests/term.php

Timestamp:

09/02/2020 12:35:36 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/term.php (modified) (6 diffs)

trunk/tests/phpunit/tests/term.php

@@ -102 +102 @@
 
         $tt = wp_add_object_terms( $posts[0], $tags[1], 'post_tag' );
-        $this->assertEquals( 1, count( $tt ) );
-        $this->assertEquals( array( $tags[1] ), wp_get_object_terms( $posts[0], 'post_tag', array( 'fields' => 'ids' ) ) );
+        $this->assertSame( 1, count( $tt ) );
+        $this->assertSame( array( $tags[1] ), wp_get_object_terms( $posts[0], 'post_tag', array( 'fields' => 'ids' ) ) );
 
         $three_tags = array( $tags[0], $tags[1], $tags[2] );
         $tt         = wp_add_object_terms( $posts[1], $three_tags, 'post_tag' );
-        $this->assertEquals( 3, count( $tt ) );
-        $this->assertEquals( $three_tags, wp_get_object_terms( $posts[1], 'post_tag', array( 'fields' => 'ids' ) ) );
+        $this->assertSame( 3, count( $tt ) );
+        $this->assertSame( $three_tags, wp_get_object_terms( $posts[1], 'post_tag', array( 'fields' => 'ids' ) ) );
 
         $this->assertTrue( wp_remove_object_terms( $posts[0], $tags[1], 'post_tag' ) );
@@ -114 +114 @@
         $this->assertInstanceOf( 'WP_Error', wp_remove_object_terms( $posts[0], $tags[1], 'non_existing_taxonomy' ) );
         $this->assertTrue( wp_remove_object_terms( $posts[1], $three_tags, 'post_tag' ) );
-        $this->assertEquals( 0, count( wp_get_object_terms( $posts[1], 'post_tag' ) ) );
+        $this->assertSame( 0, count( wp_get_object_terms( $posts[1], 'post_tag' ) ) );
 
         foreach ( $tags as $term_id ) {
@@ -178 +178 @@
 
         $this->assertInternalType( 'array', $post->post_category );
-        $this->assertEquals( 1, count( $post->post_category ) );
+        $this->assertSame( 1, count( $post->post_category ) );
         $this->assertEquals( get_option( 'default_category' ), $post->post_category[0] );
 
@@ -186 +186 @@
 
         wp_set_post_categories( $post_id, array( $term1['term_id'], $term2['term_id'] ) );
-        $this->assertEquals( 2, count( $post->post_category ) );
-        $this->assertEquals( array( $term2['term_id'], $term1['term_id'] ), $post->post_category );
+        $this->assertSame( 2, count( $post->post_category ) );
+        $this->assertSame( array( $term2['term_id'], $term1['term_id'] ), $post->post_category );
 
         wp_set_post_categories( $post_id, $term3['term_id'], true );
-        $this->assertEquals( array( $term2['term_id'], $term3['term_id'], $term1['term_id'] ), $post->post_category );
+        $this->assertSame( array( $term2['term_id'], $term3['term_id'], $term1['term_id'] ), $post->post_category );
 
         $term4 = wp_insert_term( 'Burrito', 'category' );
 
         wp_set_post_categories( $post_id, $term4['term_id'] );
-        $this->assertEquals( array( $term4['term_id'] ), $post->post_category );
+        $this->assertSame( array( $term4['term_id'] ), $post->post_category );
 
         wp_set_post_categories( $post_id, array( $term1['term_id'], $term2['term_id'] ), true );
-        $this->assertEquals( array( $term2['term_id'], $term4['term_id'], $term1['term_id'] ), $post->post_category );
+        $this->assertSame( array( $term2['term_id'], $term4['term_id'], $term1['term_id'] ), $post->post_category );
 
         wp_set_post_categories( $post_id, array(), true );
-        $this->assertEquals( 1, count( $post->post_category ) );
+        $this->assertSame( 1, count( $post->post_category ) );
         $this->assertEquals( get_option( 'default_category' ), $post->post_category[0] );
 
         wp_set_post_categories( $post_id, array() );
-        $this->assertEquals( 1, count( $post->post_category ) );
+        $this->assertSame( 1, count( $post->post_category ) );
         $this->assertEquals( get_option( 'default_category' ), $post->post_category[0] );
     }
@@ -225 +225 @@
 
         wp_set_post_categories( $post_id, $term['term_id'] );
-        $this->assertEquals( $term['term_id'], $post->post_category[0] );
+        $this->assertSame( $term['term_id'], $post->post_category[0] );
 
         wp_set_post_categories( $post_id, array() );
@@ -244 +244 @@
         $term = wp_insert_term( 'foo', $this->taxonomy );
 
-        $this->assertEquals( 0, sanitize_term_field( 'parent', 0, $term['term_id'], $this->taxonomy, 'raw' ) );
-        $this->assertEquals( 1, sanitize_term_field( 'parent', 1, $term['term_id'], $this->taxonomy, 'raw' ) );
-        $this->assertEquals( 0, sanitize_term_field( 'parent', -1, $term['term_id'], $this->taxonomy, 'raw' ) );
-        $this->assertEquals( 0, sanitize_term_field( 'parent', '', $term['term_id'], $this->taxonomy, 'raw' ) );
+        $this->assertSame( 0, sanitize_term_field( 'parent', 0, $term['term_id'], $this->taxonomy, 'raw' ) );
+        $this->assertSame( 1, sanitize_term_field( 'parent', 1, $term['term_id'], $this->taxonomy, 'raw' ) );
+        $this->assertSame( 0, sanitize_term_field( 'parent', -1, $term['term_id'], $this->taxonomy, 'raw' ) );
+        $this->assertSame( 0, sanitize_term_field( 'parent', '', $term['term_id'], $this->taxonomy, 'raw' ) );
     }