Changeset 48937 for trunk/tests/phpunit/tests/term/wpSetObjectTerms.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/term/wpSetObjectTerms.php (modified) (12 diffs)

trunk/tests/phpunit/tests/term/wpSetObjectTerms.php

@@ -114 +114 @@
             $tt = wp_set_object_terms( $id, array_values( $term_id ), $this->taxonomy );
             // Should return three term taxonomy IDs.
-            $this->assertEquals( 3, count( $tt ) );
+            $this->assertSame( 3, count( $tt ) );
         }
 
@@ -120 +120 @@
         foreach ( $term_id as $term => $id ) {
             $actual = get_objects_in_term( $id, $this->taxonomy );
-            $this->assertEquals( $ids, array_map( 'intval', $actual ) );
+            $this->assertSame( $ids, array_map( 'intval', $actual ) );
         }
 
@@ -126 +126 @@
         foreach ( array_keys( $term_id ) as $term ) {
             $t = get_term_by( 'name', $term, $this->taxonomy );
-            $this->assertEquals( 5, $t->count );
+            $this->assertSame( 5, $t->count );
         }
     }
@@ -142 +142 @@
             $tt = wp_set_object_terms( $id, $terms, $this->taxonomy );
             // Should return three term taxonomy IDs.
-            $this->assertEquals( 3, count( $tt ) );
+            $this->assertSame( 3, count( $tt ) );
             // Remember which term has which term_id.
             for ( $i = 0; $i < 3; $i++ ) {
@@ -153 +153 @@
         foreach ( $term_id as $term => $id ) {
             $actual = get_objects_in_term( $id, $this->taxonomy );
-            $this->assertEquals( $ids, array_map( 'intval', $actual ) );
+            $this->assertSame( $ids, array_map( 'intval', $actual ) );
         }
 
@@ -159 +159 @@
         foreach ( $terms as $term ) {
             $t = get_term_by( 'name', $term, $this->taxonomy );
-            $this->assertEquals( 5, $t->count );
+            $this->assertSame( 5, $t->count );
         }
     }
@@ -269 +269 @@
         // Set the initial terms.
         $tt_1 = wp_set_object_terms( $post_id, $terms_1, $this->taxonomy );
-        $this->assertEquals( 3, count( $tt_1 ) );
+        $this->assertSame( 3, count( $tt_1 ) );
 
         // Make sure they're correct.
@@ -280 +280 @@
             )
         );
-        $this->assertEquals( $terms_1, $terms );
+        $this->assertSame( $terms_1, $terms );
 
         // Change the terms.
         $tt_2 = wp_set_object_terms( $post_id, $terms_2, $this->taxonomy );
-        $this->assertEquals( 2, count( $tt_2 ) );
+        $this->assertSame( 2, count( $tt_2 ) );
 
         // Make sure they're correct.
@@ -295 +295 @@
             )
         );
-        $this->assertEquals( $terms_2, $terms );
+        $this->assertSame( $terms_2, $terms );
 
         // Make sure the term taxonomy ID for 'bar' matches.
-        $this->assertEquals( $tt_1[1], $tt_2[0] );
+        $this->assertSame( $tt_1[1], $tt_2[0] );
 
     }
@@ -313 +313 @@
         // Set the initial terms.
         $tt_1 = wp_set_object_terms( $post_id, $terms_1, $this->taxonomy );
-        $this->assertEquals( 3, count( $tt_1 ) );
+        $this->assertSame( 3, count( $tt_1 ) );
 
         // Make sure they're correct.
@@ -324 +324 @@
             )
         );
-        $this->assertEquals( $terms_1, $terms );
+        $this->assertSame( $terms_1, $terms );
 
         // Change the terms.
         $tt_2 = wp_set_object_terms( $post_id, $terms_2, $this->taxonomy );
-        $this->assertEquals( 2, count( $tt_2 ) );
+        $this->assertSame( 2, count( $tt_2 ) );
 
         // Make sure they're correct.
@@ -339 +339 @@
             )
         );
-        $this->assertEquals( $terms_2, $terms );
+        $this->assertSame( $terms_2, $terms );
 
         // Make sure the term taxonomy ID for 'bar' matches.