Changeset 48937 for trunk/tests/phpunit/tests/user/multisite.php

Timestamp:

09/02/2020 12:35:36 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/user/multisite.php (modified) (5 diffs)

trunk/tests/phpunit/tests/user/multisite.php

@@ -53 +53 @@
 
             // User should be a member of the created sites and the network's initial site.
-            $this->assertEquals( $blog_ids, $blog_ids_of_user );
+            $this->assertSame( $blog_ids, $blog_ids_of_user );
 
             $this->assertTrue( remove_user_from_blog( $user1_id, $blog_ids[0] ) );
@@ -68 +68 @@
             // The user should still be a member of all remaining sites.
             $blog_ids_of_user = array_keys( $blogs_of_user );
-            $this->assertEquals( $blog_ids, $blog_ids_of_user );
+            $this->assertSame( $blog_ids, $blog_ids_of_user );
 
             // Each site retrieved should match the expected structure.
             foreach ( $blogs_of_user as $blog_id => $blog ) {
-                $this->assertEquals( $blog_id, $blog->userblog_id );
+                $this->assertSame( $blog_id, $blog->userblog_id );
                 $this->assertTrue( isset( $blog->userblog_id ) );
                 $this->assertTrue( isset( $blog->blogname ) );
@@ -92 +92 @@
             $blogs_of_user    = get_blogs_of_user( $user1_id, true );
             $blog_ids_of_user = array_keys( $blogs_of_user );
-            $this->assertEquals( $blog_ids, $blog_ids_of_user );
+            $this->assertSame( $blog_ids, $blog_ids_of_user );
 
             // Check if sites are flagged as expected.
@@ -106 +106 @@
             // Passing false (the default) as the second parameter should retrieve only good sites.
             $blog_ids_of_user = array_keys( get_blogs_of_user( $user1_id, false ) );
-            $this->assertEquals( $blog_ids, $blog_ids_of_user );
+            $this->assertSame( $blog_ids, $blog_ids_of_user );
         }
 
@@ -370 +370 @@
             $u_obj = self::factory()->user->create_and_get();
             $this->assertFalse( wpmu_delete_user( $u_obj ) );
-            $this->assertEquals( $u_obj->ID, username_exists( $u_obj->user_login ) );
+            $this->assertSame( $u_obj->ID, username_exists( $u_obj->user_login ) );
         }