Changeset 48937 for trunk/tests/phpunit/tests/xmlrpc/mw/editPost.php

Timestamp:

09/02/2020 12:35:36 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/xmlrpc/mw/editPost.php (modified) (12 diffs)

trunk/tests/phpunit/tests/xmlrpc/mw/editPost.php

@@ -10 +10 @@
         $result = $this->myxmlrpcserver->mw_editPost( array( 1, 'username', 'password', $post ) );
         $this->assertIXRError( $result );
-        $this->assertEquals( 403, $result->code );
+        $this->assertSame( 403, $result->code );
     }
 
@@ -28 +28 @@
 
         $out = get_post( $post_id );
-        $this->assertEquals( $new_title, $out->post_title );
+        $this->assertSame( $new_title, $out->post_title );
     }
 
@@ -48 +48 @@
 
         $out = get_post( $post_id );
-        $this->assertEquals( $new_title, $out->post_title );
+        $this->assertSame( $new_title, $out->post_title );
     }
 
@@ -66 +66 @@
         $result    = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'contributor', 'contributor', $post2 ) );
         $this->assertIXRError( $result );
-        $this->assertEquals( 401, $result->code );
-
-        $out = get_post( $post_id );
-        $this->assertEquals( $original_title, $out->post_title );
+        $this->assertSame( 401, $result->code );
+
+        $out = get_post( $post_id );
+        $this->assertSame( $original_title, $out->post_title );
     }
 
@@ -105 +105 @@
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'contributor', 'contributor', $post2 ) );
         $this->assertIXRError( $result );
-        $this->assertEquals( 401, $result->code );
+        $this->assertSame( 401, $result->code );
 
         $out = get_post( $post_id );
@@ -144 +144 @@
         $post_id = wp_insert_post( $post );
 
-        $this->assertEquals( '', get_post_meta( $post_id, '_thumbnail_id', true ) );
+        $this->assertSame( '', get_post_meta( $post_id, '_thumbnail_id', true ) );
 
         // Create attachment.
@@ -175 +175 @@
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'author', 'author', $post5 ) );
         $this->assertNotIXRError( $result );
-        $this->assertEquals( '', get_post_meta( $post_id, '_thumbnail_id', true ) );
+        $this->assertSame( '', get_post_meta( $post_id, '_thumbnail_id', true ) );
 
         remove_theme_support( 'post-thumbnails' );
@@ -200 +200 @@
 
         $out = get_post( $post_id );
-        $this->assertEquals( $post2['title'], $out->post_title );
+        $this->assertSame( $post2['title'], $out->post_title );
 
         $post3  = array(
@@ -211 +211 @@
 
         $out = get_post( $post_id );
-        $this->assertEquals( $post2['title'], $out->post_title );
-        $this->assertEquals( $post3['description'], $out->post_content );
+        $this->assertSame( $post2['title'], $out->post_title );
+        $this->assertSame( $post3['description'], $out->post_content );
 
         $post4  = array(
@@ -223 +223 @@
 
         $out = get_post( $post_id );
-        $this->assertEquals( $post2['title'], $out->post_title );
-        $this->assertEquals( $post3['description'], $out->post_content );
-        $this->assertEquals( $post4['mt_excerpt'], $out->post_excerpt );
+        $this->assertSame( $post2['title'], $out->post_title );
+        $this->assertSame( $post3['description'], $out->post_content );
+        $this->assertSame( $post4['mt_excerpt'], $out->post_excerpt );
     }
 
@@ -260 +260 @@
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'contributor', 'contributor', $post2 ) );
         $this->assertIXRError( $result );
-        $this->assertEquals( $result->code, 401 );
+        $this->assertSame( $result->code, 401 );
     }
 
@@ -328 +328 @@
 
         $after = get_post( $post_id );
-        $this->assertEquals( 'future', $after->post_status );
+        $this->assertSame( 'future', $after->post_status );
 
         $future_date_string = strftime( '%Y-%m-%d %H:%M:%S', $future_time );
-        $this->assertEquals( $future_date_string, $after->post_date );
+        $this->assertSame( $future_date_string, $after->post_date );
     }
 }