Changeset 48937 for trunk/tests/phpunit/tests/xmlrpc/wp/getTerms.php

Timestamp:

09/02/2020 12:35:36 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getTerms.php (modified) (9 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getTerms.php

@@ -9 +9 @@
         $result = $this->myxmlrpcserver->wp_getTerms( array( 1, 'username', 'password', 'category' ) );
         $this->assertIXRError( $result );
-        $this->assertEquals( 403, $result->code );
+        $this->assertSame( 403, $result->code );
     }
 
@@ -17 +17 @@
         $result = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', '' ) );
         $this->assertIXRError( $result );
-        $this->assertEquals( 403, $result->code );
-        $this->assertEquals( __( 'Invalid taxonomy.' ), $result->message );
+        $this->assertSame( 403, $result->code );
+        $this->assertSame( __( 'Invalid taxonomy.' ), $result->message );
     }
 
@@ -26 +26 @@
         $result = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', 'not_existing' ) );
         $this->assertIXRError( $result );
-        $this->assertEquals( 403, $result->code );
-        $this->assertEquals( __( 'Invalid taxonomy.' ), $result->message );
+        $this->assertSame( 403, $result->code );
+        $this->assertSame( __( 'Invalid taxonomy.' ), $result->message );
     }
 
@@ -35 +35 @@
         $result = $this->myxmlrpcserver->wp_getTerms( array( 1, 'subscriber', 'subscriber', 'category' ) );
         $this->assertIXRError( $result );
-        $this->assertEquals( 401, $result->code );
-        $this->assertEquals( __( 'Sorry, you are not allowed to assign terms in this taxonomy.' ), $result->message );
+        $this->assertSame( 401, $result->code );
+        $this->assertSame( __( 'Sorry, you are not allowed to assign terms in this taxonomy.' ), $result->message );
     }
 
@@ -78 +78 @@
         $this->assertNotIXRError( $results );
 
-        $this->assertEquals( $num_terms, count( $results ) );
+        $this->assertSame( $num_terms, count( $results ) );
         foreach ( $results as $term ) {
-            $this->assertEquals( $tax_name, $term['taxonomy'] );
+            $this->assertSame( $tax_name, $term['taxonomy'] );
         }
 
@@ -87 +87 @@
         $results2 = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', $tax_name, $filter ) );
         $this->assertNotIXRError( $results );
-        $this->assertEquals( 5, count( $results2 ) );
-        $this->assertEquals( $results[1]['term_id'], $results2[1]['term_id'] ); // Check one of the terms.
+        $this->assertSame( 5, count( $results2 ) );
+        $this->assertSame( $results[1]['term_id'], $results2[1]['term_id'] ); // Check one of the terms.
 
         $filter['offset'] = 10;
         $results3         = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', $tax_name, $filter ) );
         $this->assertNotIXRError( $results3 );
-        $this->assertEquals( $num_terms - 10, count( $results3 ) );
-        $this->assertEquals( $results[11]['term_id'], $results3[1]['term_id'] );
+        $this->assertSame( $num_terms - 10, count( $results3 ) );
+        $this->assertSame( $results[11]['term_id'], $results3[1]['term_id'] );
 
         // Test hide_empty (since none have been attached to posts yet, all should be hidden.
@@ -100 +100 @@
         $results4 = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', $tax_name, $filter ) );
         $this->assertNotIXRError( $results4 );
-        $this->assertEquals( 0, count( $results4 ) );
+        $this->assertSame( 0, count( $results4 ) );
 
         unset( $GLOBALS['wp_taxonomies'][ $tax_name ] );
@@ -141 +141 @@
         $results = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', 'category', $filter ) );
         $this->assertNotIXRError( $results );
-        $this->assertEquals( 1, count( $results ) );
-        $this->assertEquals( $name, $results[0]['name'] );
+        $this->assertSame( 1, count( $results ) );
+        $this->assertSame( $name, $results[0]['name'] );
         $this->assertEquals( $name_id, $results[0]['term_id'] );
 
@@ -149 +149 @@
         $results2 = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', 'category', $filter ) );
         $this->assertNotIXRError( $results2 );
-        $this->assertEquals( 1, count( $results2 ) );
-        $this->assertEquals( $name, $results2[0]['name'] );
+        $this->assertSame( 1, count( $results2 ) );
+        $this->assertSame( $name, $results2[0]['name'] );
         $this->assertEquals( $name_id, $results2[0]['term_id'] );
     }