Changeset 48939 for trunk/tests/phpunit/tests/ajax/UpdatePlugin.php

Timestamp:

09/04/2020 07:01:00 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Introduce assertSameSets() and assertSameSetsWithIndex(), and use them where appropriate.

This ensures that not only the array values being compared are equal, but also that their type is the same.

These new methods replace most of the existing instances of assertEqualSets() and assertEqualSetsWithIndex().

Going forward, stricter type checking by using assertSameSets() or assertSameSetsWithIndex() should generally be preferred, to make the tests more reliable.

Follow-up to [48937].

See #38266.

File:

• trunk/tests/phpunit/tests/ajax/UpdatePlugin.php (modified) (5 diffs)

trunk/tests/phpunit/tests/ajax/UpdatePlugin.php

@@ -42 +42 @@
         );
 
-        $this->assertEqualSets( $expected, $response );
+        $this->assertSameSets( $expected, $response );
     }
 
@@ -68 +68 @@
         );
 
-        $this->assertEqualSets( $expected, $response );
+        $this->assertSameSets( $expected, $response );
     }
 
@@ -91 +91 @@
                 'update'       => 'plugin',
                 'slug'         => 'foo',
-                'errorMessage' => 'Sorry, you are not allowed to update plugins for this site.',
                 'oldVersion'   => '',
                 'newVersion'   => '',
+                'errorMessage' => 'Sorry, you are not allowed to update plugins for this site.',
             ),
         );
 
-        $this->assertEqualSets( $expected, $response );
+        $this->assertSameSets( $expected, $response );
     }
 
@@ -122 +122 @@
                 'update'       => 'plugin',
                 'slug'         => 'foo',
-                'errorMessage' => 'Sorry, you are not allowed to update plugins for this site.',
                 'oldVersion'   => '',
                 'newVersion'   => '',
+                'errorMessage' => 'Sorry, you are not allowed to update plugins for this site.',
             ),
         );
 
-        $this->assertEqualSets( $expected, $response );
+        $this->assertSameSets( $expected, $response );
     }
 
@@ -156 +156 @@
                 'update'       => 'plugin',
                 'slug'         => 'hello-dolly',
+                'oldVersion'   => 'Version 1.7.2',
+                'newVersion'   => '',
                 'plugin'       => 'hello.php',
                 'pluginName'   => 'Hello Dolly',
+                'debug'        => array( 'The plugin is at the latest version.' ),
                 'errorMessage' => 'The plugin is at the latest version.',
-                'oldVersion'   => 'Version 1.7.2',
-                'newVersion'   => '',
-                'debug'        => array( 'The plugin is at the latest version.' ),
             ),
         );
 
-        $this->assertEqualSets( $expected, $response );
+        $this->assertSameSets( $expected, $response );
     }
 }