Changeset 48939 for trunk/tests/phpunit/tests/post/getPages.php

Timestamp:

09/04/2020 07:01:00 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Introduce assertSameSets() and assertSameSetsWithIndex(), and use them where appropriate.

This ensures that not only the array values being compared are equal, but also that their type is the same.

These new methods replace most of the existing instances of assertEqualSets() and assertEqualSetsWithIndex().

Going forward, stricter type checking by using assertSameSets() or assertSameSetsWithIndex() should generally be preferred, to make the tests more reliable.

Follow-up to [48937].

See #38266.

File:

• trunk/tests/phpunit/tests/post/getPages.php (modified) (17 diffs)

trunk/tests/phpunit/tests/post/getPages.php

@@ -125 +125 @@
 
         $cached_ids = wp_list_pluck( $cached, 'ID' );
-        $this->assertEqualSets( array( $posts[0] ), $cached_ids );
+        $this->assertSameSets( array( $posts[0] ), $cached_ids );
 
         add_post_meta( $posts[1], 'foo', 'bar' );
@@ -137 +137 @@
 
         $found_ids = wp_list_pluck( $found, 'ID' );
-        $this->assertEqualSets( $posts, $found_ids );
+        $this->assertSameSets( $posts, $found_ids );
     }
 
@@ -162 +162 @@
 
         $cached_ids = wp_list_pluck( $cached, 'ID' );
-        $this->assertEqualSets( $posts, $cached_ids );
+        $this->assertSameSets( $posts, $cached_ids );
 
         update_post_meta( $posts[1], 'foo', 'baz' );
@@ -174 +174 @@
 
         $found_ids = wp_list_pluck( $found, 'ID' );
-        $this->assertEqualSets( array( $posts[0] ), $found_ids );
+        $this->assertSameSets( array( $posts[0] ), $found_ids );
     }
 
@@ -199 +199 @@
 
         $cached_ids = wp_list_pluck( $cached, 'ID' );
-        $this->assertEqualSets( $posts, $cached_ids );
+        $this->assertSameSets( $posts, $cached_ids );
 
         delete_post_meta( $posts[1], 'foo' );
@@ -211 +211 @@
 
         $found_ids = wp_list_pluck( $found, 'ID' );
-        $this->assertEqualSets( array( $posts[0] ), $found_ids );
+        $this->assertSameSets( array( $posts[0] ), $found_ids );
     }
 
@@ -236 +236 @@
 
         $cached_ids = wp_list_pluck( $cached, 'ID' );
-        $this->assertEqualSets( $posts, $cached_ids );
+        $this->assertSameSets( $posts, $cached_ids );
 
         delete_post_meta_by_key( 'foo' );
@@ -248 +248 @@
 
         $found_ids = wp_list_pluck( $found, 'ID' );
-        $this->assertEqualSets( array(), $found_ids );
+        $this->assertSameSets( array(), $found_ids );
     }
 
@@ -341 +341 @@
             )
         );
-        $this->assertEqualSets( array( $page_id1 ), wp_list_pluck( $pages, 'ID' ) );
+        $this->assertSameSets( array( $page_id1 ), wp_list_pluck( $pages, 'ID' ) );
 
         $pages = get_pages(
@@ -349 +349 @@
             )
         );
-        $this->assertEqualSets( array( $page_id2, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
+        $this->assertSameSets( array( $page_id2, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
 
         $pages = get_pages(
@@ -357 +357 @@
             )
         );
-        $this->assertEqualSets( array( $page_id2, $page_id3, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
+        $this->assertSameSets( array( $page_id2, $page_id3, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
 
         $pages = get_pages( array( 'parent' => 0 ) );
-        $this->assertEqualSets( array( $page_id1 ), wp_list_pluck( $pages, 'ID' ) );
+        $this->assertSameSets( array( $page_id1 ), wp_list_pluck( $pages, 'ID' ) );
 
         $pages = get_pages( array( 'parent' => $page_id1 ) );
-        $this->assertEqualSets( array( $page_id2, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
+        $this->assertSameSets( array( $page_id2, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
 
         $pages = get_pages( array( 'parent' => array( $page_id1, $page_id2 ) ) );
-        $this->assertEqualSets( array( $page_id2, $page_id3, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
+        $this->assertSameSets( array( $page_id2, $page_id3, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
     }
 
@@ -393 +393 @@
             )
         );
-        $this->assertEqualSets( $child_ids, $post_ids );
+        $this->assertSameSets( $child_ids, $post_ids );
     }
 
@@ -443 +443 @@
          */
 
-        $this->assertEqualSets( array( $page_1, $page_2, $page_4, $page_3 ), wp_list_pluck( $pages, 'ID' ) );
+        $this->assertSameSets( array( $page_1, $page_2, $page_4, $page_3 ), wp_list_pluck( $pages, 'ID' ) );
     }
 
@@ -489 +489 @@
         $found_pages = wp_list_filter( $pages, array( 'post_parent' => 0 ) );
 
-        $this->assertEqualSets( array( $page_1, $page_2 ), wp_list_pluck( $found_pages, 'ID' ) );
+        $this->assertSameSets( array( $page_1, $page_2 ), wp_list_pluck( $found_pages, 'ID' ) );
     }
 
@@ -525 +525 @@
          */
 
-        $this->assertEqualSets( array( $page_1, $page_2, $page_3, $page_4 ), wp_list_pluck( $pages, 'ID' ) );
+        $this->assertSameSets( array( $page_1, $page_2, $page_3, $page_4 ), wp_list_pluck( $pages, 'ID' ) );
     }
 
@@ -568 +568 @@
          */
 
-        $this->assertEqualSets( array( $page_3, $page_4, $page_5 ), wp_list_pluck( $pages, 'ID' ) );
+        $this->assertSameSets( array( $page_3, $page_4, $page_5 ), wp_list_pluck( $pages, 'ID' ) );
     }
 
@@ -615 +615 @@
          * hierarchically anyway in order of creation: 3, 4, 5.
          */
-        $this->assertEqualSets( array( $page_3, $page_4, $page_5 ), wp_list_pluck( $pages, 'ID' ) );
+        $this->assertSameSets( array( $page_3, $page_4, $page_5 ), wp_list_pluck( $pages, 'ID' ) );
 
         // How it should work.
         $found_pages = wp_list_filter( $pages, array( 'post_parent' => $page_1 ) );
-        $this->assertEqualSets( array( $page_3, $page_5 ), wp_list_pluck( $found_pages, 'ID' ) );
+        $this->assertSameSets( array( $page_3, $page_5 ), wp_list_pluck( $found_pages, 'ID' ) );
 
     }