Context Navigation

← Previous Change
Next Change →

rest-attachments-controller.php

Timestamp:

09/04/2020 07:01:00 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: Introduce assertSameSets() and assertSameSetsWithIndex(), and use them where appropriate.

This ensures that not only the array values being compared are equal, but also that their type is the same.

These new methods replace most of the existing instances of assertEqualSets() and assertEqualSetsWithIndex().

Going forward, stricter type checking by using assertSameSets() or assertSameSetsWithIndex() should generally be preferred, to make the tests more reliable.

Follow-up to [48937].

See #38266.

File:

: 1 edited

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

r48937	r48939
221	221	$media_types[] = 'text';
222	222	}
223		$this->assert~~Equal~~Sets( $media_types, $data['endpoints'][0]['args']['media_type']['enum'] );
	223	$this->assertSameSets( $media_types, $data['endpoints'][0]['args']['media_type']['enum'] );
224	224	}
225	225

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 48939 for trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

Legend:

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

Download in other formats: