Make WordPress Core

Changeset 48943


Ignore:
Timestamp:
09/05/2020 12:31:03 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Comments: Rename WP_Comments_List_Table::comment_status_dropdown() to ::comment_type_dropdown().

This better reflects the purpose of the method, which doesn't have anything to do with a comment status.

Follow-up to [48521].

Props davidbaumwald, johnbillion, SergeyBiryukov.
Fixes #51248.

Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-comments-list-table.php

    r48941 r48943  
    397397            ob_start();
    398398
    399             $this->comment_status_dropdown( $comment_type );
     399            $this->comment_type_dropdown( $comment_type );
    400400
    401401            /**
     
    476476     *
    477477     * @since 5.5.0
     478     * @since 5.6.0 Renamed from `comment_status_dropdown()` to `comment_type_dropdown()`.
    478479     *
    479480     * @param string $comment_type The current comment type slug.
    480481     */
    481     protected function comment_status_dropdown( $comment_type ) {
     482    protected function comment_type_dropdown( $comment_type ) {
    482483        /**
    483484         * Filters the comment types shown in the drop-down menu on the Comments list table.
  • trunk/tests/phpunit/tests/admin/includesListTable.php

    r48521 r48943  
    320320     * @ticket 40188
    321321     */
    322     public function test_filter_comment_status_dropdown_should_be_shown_if_there_are_comments() {
     322    public function test_filter_comment_type_dropdown_should_be_shown_if_there_are_comments() {
    323323        $post_id    = self::factory()->post->create();
    324324        $comment_id = self::factory()->comment->create(
Note: See TracChangeset for help on using the changeset viewer.