Changeset 48943

Timestamp:

09/05/2020 12:31:03 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Comments: Rename WP_Comments_List_Table::comment_status_dropdown() to ::comment_type_dropdown().

This better reflects the purpose of the method, which doesn't have anything to do with a comment status.

Follow-up to [48521].

Props davidbaumwald, johnbillion, SergeyBiryukov.
Fixes #51248.

Location:

trunk

Files:

• src/wp-admin/includes/class-wp-comments-list-table.php (modified) (2 diffs)
• tests/phpunit/tests/admin/includesListTable.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -397 +397 @@
             ob_start();
 
-            $this->comment_status_dropdown( $comment_type );
+            $this->comment_type_dropdown( $comment_type );
 
             /**
@@ -476 +476 @@
      *
      * @since 5.5.0
+     * @since 5.6.0 Renamed from `comment_status_dropdown()` to `comment_type_dropdown()`.
      *
      * @param string $comment_type The current comment type slug.
      */
-    protected function comment_status_dropdown( $comment_type ) {
+    protected function comment_type_dropdown( $comment_type ) {
         /**
          * Filters the comment types shown in the drop-down menu on the Comments list table.

trunk/tests/phpunit/tests/admin/includesListTable.php

@@ -320 +320 @@
      * @ticket 40188
      */
-    public function test_filter_comment_status_dropdown_should_be_shown_if_there_are_comments() {
+    public function test_filter_comment_type_dropdown_should_be_shown_if_there_are_comments() {
         $post_id    = self::factory()->post->create();
         $comment_id = self::factory()->comment->create(