Changeset 48951 for trunk/tests/phpunit/tests/rest-api/rest-controller.php

Timestamp:

09/07/2020 02:35:52 AM (4 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Extract WP_REST_Controller::get_endpoint_args_for_item_schema() to a standalone function.

This method is useful whenever a JSON Schema needs to be converted to a format suitable for argument validation with WP_REST_Request. Moving the logic into a standalone function allows developers to use it outside of the WP_REST_Controller context.

Props pentatonicfunk.
Fixes #50876.

File:

• trunk/tests/phpunit/tests/rest-api/rest-controller.php (modified) (4 diffs)

trunk/tests/phpunit/tests/rest-api/rest-controller.php

@@ -223 +223 @@
     }
 
+    /**
+     * @ticket 50876
+     */
+    public function test_get_endpoint_args_for_item_schema() {
+        $controller = new WP_REST_Test_Controller();
+        $args       = $controller->get_endpoint_args_for_item_schema();
+
+        $this->assertArrayHasKey( 'somestring', $args );
+        $this->assertArrayHasKey( 'someinteger', $args );
+        $this->assertArrayHasKey( 'someboolean', $args );
+        $this->assertArrayHasKey( 'someurl', $args );
+        $this->assertArrayHasKey( 'somedate', $args );
+        $this->assertArrayHasKey( 'someemail', $args );
+        $this->assertArrayHasKey( 'somehex', $args );
+        $this->assertArrayHasKey( 'someuuid', $args );
+        $this->assertArrayHasKey( 'someenum', $args );
+        $this->assertArrayHasKey( 'someargoptions', $args );
+        $this->assertArrayHasKey( 'somedefault', $args );
+        $this->assertArrayHasKey( 'somearray', $args );
+        $this->assertArrayHasKey( 'someobject', $args );
+    }
+
     public function test_get_endpoint_args_for_item_schema_description() {
         $controller = new WP_REST_Test_Controller();
-        $args       = $controller->get_endpoint_args_for_item_schema();
-        $this->assertSame( 'A pretty string.', $args['somestring']['description'] );
+        $args       = rest_get_endpoint_args_for_schema( $controller->get_item_schema() );
+
+        $this->assertEquals( 'A pretty string.', $args['somestring']['description'] );
         $this->assertFalse( isset( $args['someinteger']['description'] ) );
     }
@@ -233 +256 @@
 
         $controller = new WP_REST_Test_Controller();
-        $args       = $controller->get_endpoint_args_for_item_schema();
+        $args       = rest_get_endpoint_args_for_schema( $controller->get_item_schema() );
 
         $this->assertFalse( $args['someargoptions']['required'] );
@@ -242 +265 @@
 
         $controller = new WP_REST_Test_Controller();
-
-        $args = $controller->get_endpoint_args_for_item_schema();
+        $args       = rest_get_endpoint_args_for_schema( $controller->get_item_schema() );
 
         $this->assertSame( 'a', $args['somedefault']['default'] );
@@ -254 +276 @@
 
         $controller = new WP_REST_Test_Controller();
-        $args       = $controller->get_endpoint_args_for_item_schema();
+        $args       = rest_get_endpoint_args_for_schema( $controller->get_item_schema() );
 
         foreach ( array( 'minLength', 'maxLength', 'pattern' ) as $property ) {