Changeset 48953

Timestamp:

09/07/2020 03:26:24 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Remove the polyfill for assertNotFalse().

assertNotFalse() is available in PHPUnit since version 4.0.

The polyfill was introduced back when WordPress still supported PHP 5.2 and PHPUnit 3.6.x, and is now redundant.

Follow-up to [39919], [45058], [47880].

See #38266.

Location:

trunk/tests/phpunit/includes

Files:

• phpunit7/testcase.php (modified) (1 diff)
• testcase.php (modified) (1 diff)

trunk/tests/phpunit/includes/phpunit7/testcase.php

@@ -13 +13 @@
  */
 class WP_UnitTestCase extends WP_UnitTestCase_Base {
-
-    /**
-     * Asserts that a condition is not false.
-     *
-     * This method has been backported from a more recent PHPUnit version,
-     * as tests running on PHP 5.2 use PHPUnit 3.6.x.
-     *
-     * @since 4.7.4
-     *
-     * @param bool   $condition Condition to check.
-     * @param string $message   Optional. Message to display when the assertion fails.
-     *
-     * @throws PHPUnit_Framework_AssertionFailedError
-     */
-    public static function assertNotFalse( $condition, string $message = '' ): void {
-        self::assertThat( $condition, self::logicalNot( self::isFalse() ), $message );
-    }
 
     /**

trunk/tests/phpunit/includes/testcase.php

@@ -13 +13 @@
  */
 class WP_UnitTestCase extends WP_UnitTestCase_Base {
-
-    /**
-     * Asserts that a condition is not false.
-     *
-     * This method has been backported from a more recent PHPUnit version,
-     * as tests running on PHP 5.2 use PHPUnit 3.6.x.
-     *
-     * @since 4.7.4
-     *
-     * @param bool   $condition Condition to check.
-     * @param string $message   Optional. Message to display when the assertion fails.
-     *
-     * @throws PHPUnit_Framework_AssertionFailedError
-     */
-    public static function assertNotFalse( $condition, $message = '' ) {
-        self::assertThat( $condition, self::logicalNot( self::isFalse() ), $message );
-    }
 
     /**