Changeset 48956 for branches/5.5

Timestamp:

09/07/2020 01:05:15 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Media: In wp_ajax_image_editor(), check if the error property exists before accessing it.

This avoids a PHP notice when editing an image.

Follow-up to [48375].

Props Mista-Flo.
Merges [48946] to the 5.5 branch.
Fixes #51251.

Location:

branches/5.5

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/ajax-actions.php (modified) (2 diffs)

branches/5.5/src/wp-admin/includes/ajax-actions.php

@@ -2605 +2605 @@
 
     $msg = false;
+
     switch ( $_POST['do'] ) {
         case 'save':
             $msg = wp_save_image( $attachment_id );
-            if ( $msg->error ) {
+            if ( ! empty( $msg->error ) ) {
                 wp_send_json_error( $msg );
             }
@@ -2626 +2627 @@
     $html = ob_get_clean();
 
-    if ( $msg->error ) {
+    if ( ! empty( $msg->error ) ) {
         wp_send_json_error(
             array(