Changeset 48961 for trunk

Timestamp:

09/09/2020 03:53:50 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove unnecessary reference sign from get_comment() definition.

This fixes a PHP 8 "argument must be passed by reference, value given" error when using array_map( 'get_comment', ... ).

Object variables in PHP 5+ contain a reference to the object, and it's the reference that's passed around.

Note: This reverts [48838], which is now redundant.

Follow-up to a similar change for get_post() in [21572].

See #50913.

Location:

trunk/src/wp-includes

Files:

• class-wp-comment-query.php (modified) (1 diff)
• comment.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -482 +482 @@
 
         // Convert to WP_Comment instances.
-        array_walk( $_comments, 'get_comment' );
-        $comments = $_comments;
+        $comments = array_map( 'get_comment', $_comments );
 
         if ( $this->query_vars['hierarchical'] ) {

trunk/src/wp-includes/comment.php

@@ -193 +193 @@
  * @return WP_Comment|array|null Depends on $output value.
  */
-function get_comment( &$comment = null, $output = OBJECT ) {
+function get_comment( $comment = null, $output = OBJECT ) {
     if ( empty( $comment ) && isset( $GLOBALS['comment'] ) ) {
         $comment = $GLOBALS['comment'];