Changeset 48974

Timestamp:

09/13/2020 03:19:40 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correct assertion in Tests_DB::test_prepare_incorrect_arg_count().

On failure, wpdb::prepare() returns either an empty string or null, not false.

The test only passed accidentally due to assertEquals() not performing a strict type check.

Follow-up to [41662].

See #38266.

File:

• trunk/tests/phpunit/tests/db.php (modified) (2 diffs)

trunk/tests/phpunit/tests/db.php

@@ -428 +428 @@
                 // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged,WordPress.DB.PreparedSQL
                 $prepared = @$wpdb->prepare( $query, ...$args );
-                $this->assertEquals( $expected, $prepared );
+                $this->assertSame( $expected, $prepared );
         }
 
@@ -443 +443 @@
                                 "SELECT * FROM $wpdb->users WHERE id = %%%d AND user_login = %s",
                                 array( 1 ),
-                                false,
+                                '',
                         ),
                         array(