Changeset 48979 for trunk/tests/phpunit/tests/db.php

Timestamp:

09/16/2020 01:33:42 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: Revert [48973].

These tests ensure that a _doing_it_wrong() notice is thrown when wpdb::prepare() is called incorrectly, but also that the function will still handle the provided input as correctly as possible.

Disabling these tests on PHP 8 hides a problem, i.e. the function will no longer throw a notice and handle things correctly, it will now cause a white screen of death due to a fatal error.

That is a backward compatibility break, and wpdb::prepare() should be updated instead to maintain the original behaviour on PHP 8.

Props jrf, ayeshrajans.
See #50913, #50639.

File:

• trunk/tests/phpunit/tests/db.php (modified) (3 diffs)

trunk/tests/phpunit/tests/db.php

@@ -380 +380 @@
         /**
          * @expectedIncorrectUsage wpdb::prepare
-         * @requires PHP < 8.0
          */
         function test_prepare_sprintf_invalid_args() {
@@ -403 +402 @@
         /**
          * @expectedIncorrectUsage wpdb::prepare
-         * @requires PHP < 8.0
          */
         function test_prepare_vsprintf_invalid_args() {
@@ -421 +419 @@
          * @dataProvider data_prepare_incorrect_arg_count
          * @expectedIncorrectUsage wpdb::prepare
-         * @requires PHP < 8.0
          */
         public function test_prepare_incorrect_arg_count( $query, $args, $expected ) {