Changeset 48993

Timestamp:

09/18/2020 10:56:27 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: Fix the failure in test_get_weekday_undefined_index() on PHP 8.

The test ensures that WP_Locale::get_weekday() throws an "undefined offset" notice when called with an incorrect $weekday_number parameter.

In PHP 8, that notice is now a warning, so the test needs to be adjusted accordingly.

See #50913.

File:

• trunk/tests/phpunit/tests/locale.php (modified) (1 diff)

trunk/tests/phpunit/tests/locale.php

@@ -26 +26 @@
         }
 
-        /**
-         * @expectedException PHPUnit_Framework_Error_Notice
-         */
         public function test_get_weekday_undefined_index() {
+                if ( PHP_VERSION_ID >= 80000 ) {
+                        $this->expectException( 'PHPUnit_Framework_Error_Warning' );
+                } else {
+                        $this->expectException( 'PHPUnit_Framework_Error_Notice' );
+                }
+
                 $this->locale->get_weekday( 7 );
         }