Changeset 49000

Timestamp:

09/19/2020 01:20:48 AM (6 years ago)

Author:

peterwilsoncc

Message:

Posts, Post Types: Ensure default terms are added by wp_publish_post().

Transitioning posts from auto-draft to publish via wp_publish_post() could result in published posts without the default category or custom taxonomy default terms.

Props frank-klein, TimothyBlynJacobs, peterwilsoncc.
Fixes #51292.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post/wpPublishPosts.php (added)
• tests/phpunit/tests/term/termCounts.php (added)

trunk/src/wp-includes/post.php

@@ -4376 +4376 @@
         }
 
+        // Ensure at least one term is applied for taxonomies with a default term.
+        foreach ( get_object_taxonomies( $post->post_type, 'object' ) as $taxonomy => $tax_object ) {
+                // Skip taxonomy if no default term is set.
+                if (
+                        'category' !== $taxonomy &&
+                        empty( $tax_object->default_term )
+                ) {
+                        continue;
+                }
+
+                // Do not modify previously set terms.
+                if ( ! empty( get_the_terms( $post, $taxonomy ) ) ) {
+                        continue;
+                }
+
+                if ( 'category' === $taxonomy ) {
+                        $default_term_id = (int) get_option( 'default_category', 0 );
+                } else {
+                        $default_term_id = (int) get_option( 'default_term_' . $taxonomy, 0 );
+                }
+
+                if ( ! $default_term_id ) {
+                        continue;
+                }
+                wp_set_post_terms( $post->ID, array( $default_term_id ), $taxonomy );
+        }
+
         $wpdb->update( $wpdb->posts, array( 'post_status' => 'publish' ), array( 'ID' => $post->ID ) );