Changeset 49003

Timestamp:

09/19/2020 10:34:54 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Speed up slashed data tests by reusing shared fixtures.

Follow-up to [35249].

See #51344.

Location:

trunk/tests/phpunit/tests

Files:

• attachment/slashes.php (modified) (1 diff)
• comment/slashes.php (modified) (1 diff)
• option/slashes.php (modified) (1 diff)
• post/slashes.php (modified) (1 diff)
• term/slashes.php (modified) (1 diff)
• user/slashes.php (modified) (1 diff)

trunk/tests/phpunit/tests/attachment/slashes.php

@@ -7 +7 @@
  */
 class Tests_Attachment_Slashes extends WP_UnitTestCase {
+    protected static $author_id;
+
+    public static function wpSetUpBeforeClass( $factory ) {
+        self::$author_id = $factory->user->create( array( 'role' => 'editor' ) );
+    }
+
     function setUp() {
         parent::setUp();
-        $this->author_id = self::factory()->user->create( array( 'role' => 'editor' ) );
-        wp_set_current_user( $this->author_id );
+
+        wp_set_current_user( self::$author_id );
 
         // It is important to test with both even and odd numbered slashes,

trunk/tests/phpunit/tests/comment/slashes.php

@@ -7 +7 @@
  */
 class Tests_Comment_Slashes extends WP_UnitTestCase {
+    protected static $author_id;
+
+    public static function wpSetUpBeforeClass( $factory ) {
+        // We need an admin user to bypass comment flood protection.
+        self::$author_id = $factory->user->create( array( 'role' => 'administrator' ) );
+    }
+
     function setUp() {
         parent::setUp();
-        // We need an admin user to bypass comment flood protection.
-        $this->author_id = self::factory()->user->create( array( 'role' => 'administrator' ) );
-        wp_set_current_user( $this->author_id );
+
+        wp_set_current_user( self::$author_id );
 
         // It is important to test with both even and odd numbered slashes,

trunk/tests/phpunit/tests/option/slashes.php

@@ -7 +7 @@
  */
 class Tests_Option_Slashes extends WP_UnitTestCase {
+
     function setUp() {
         parent::setUp();
+
         // It is important to test with both even and odd numbered slashes,
         // as KSES does a strip-then-add slashes in some of its function calls.

trunk/tests/phpunit/tests/post/slashes.php

@@ -7 +7 @@
  */
 class Tests_Post_Slashes extends WP_UnitTestCase {
+    protected static $author_id;
+
+    public static function wpSetUpBeforeClass( $factory ) {
+        self::$author_id = $factory->user->create( array( 'role' => 'editor' ) );
+    }
+
     function setUp() {
         parent::setUp();
-        $this->author_id = self::factory()->user->create( array( 'role' => 'editor' ) );
 
-        wp_set_current_user( $this->author_id );
+        wp_set_current_user( self::$author_id );
 
         // It is important to test with both even and odd numbered slashes,

trunk/tests/phpunit/tests/term/slashes.php

@@ -7 +7 @@
  */
 class Tests_Term_Slashes extends WP_Ajax_UnitTestCase {
+    protected static $author_id;
+
+    public static function wpSetUpBeforeClass( $factory ) {
+        self::$author_id = $factory->user->create( array( 'role' => 'administrator' ) );
+    }
+
     function setUp() {
         parent::setUp();
-        $this->author_id = self::factory()->user->create( array( 'role' => 'administrator' ) );
 
-        wp_set_current_user( $this->author_id );
+        wp_set_current_user( self::$author_id );
 
         $this->slash_1 = 'String with 1 slash \\';

trunk/tests/phpunit/tests/user/slashes.php

@@ -7 +7 @@
  */
 class Tests_User_Slashes extends WP_UnitTestCase {
+    protected static $author_id;
+
+    public static function wpSetUpBeforeClass( $factory ) {
+        self::$author_id = $factory->user->create( array( 'role' => 'administrator' ) );
+    }
+
     function setUp() {
         parent::setUp();
-        $this->author_id = self::factory()->user->create( array( 'role' => 'administrator' ) );
-
-        wp_set_current_user( $this->author_id );
+
+        wp_set_current_user( self::$author_id );
 
         // It is important to test with both even and odd numbered slashes,