Changeset 49024 for trunk/tests/phpunit/tests/image/functions.php

Timestamp:

09/21/2020 11:34:06 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: Convert the checks for imagejpeg() function availability to use the @requires annotation.

This better utilizes the PHPUnit native functionality.

Props ayeshrajans, jrf, johnbillion.
Fixes #50639. See #50640.

File:

• trunk/tests/phpunit/tests/image/functions.php (modified) (2 diffs)

trunk/tests/phpunit/tests/image/functions.php

@@ -349 +349 @@
         }
 
+        /**
+         * @requires function imagejpeg
+         */
         public function test_wp_crop_image_file() {
-                if ( ! function_exists( 'imagejpeg' ) ) {
-                        $this->fail( 'jpeg support unavailable' );
-                }
-
                 $file = wp_crop_image(
                         DIR_TESTDATA . '/images/canola.jpg',
@@ -373 +372 @@
         }
 
+        /**
+         * @requires function imagejpeg
+         */
         public function test_wp_crop_image_url() {
-                if ( ! function_exists( 'imagejpeg' ) ) {
-                        $this->fail( 'jpeg support unavailable' );
-                }
-
                 if ( ! extension_loaded( 'openssl' ) ) {
                         $this->markTestSkipped( 'Tests_Image_Functions::test_wp_crop_image_url() requires openssl.' );