Changeset 49024 for trunk/tests/phpunit/tests/post/attachments.php

Timestamp:

09/21/2020 11:34:06 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Convert the checks for imagejpeg() function availability to use the @requires annotation.

This better utilizes the PHPUnit native functionality.

Props ayeshrajans, jrf, johnbillion.
Fixes #50639. See #50640.

File:

• trunk/tests/phpunit/tests/post/attachments.php (modified) (3 diffs)

trunk/tests/phpunit/tests/post/attachments.php

@@ -55 +55 @@
     }
 
+    /**
+     * @requires function imagejpeg
+     */
     function test_insert_image_thumb_only() {
-        if ( ! function_exists( 'imagejpeg' ) ) {
-            $this->fail( 'jpeg support unavailable' );
-        }
-
         update_option( 'medium_size_w', 0 );
         update_option( 'medium_size_h', 0 );
@@ -107 +106 @@
     }
 
+    /**
+     * @requires function imagejpeg
+     */
     function test_insert_image_medium_sizes() {
-        if ( ! function_exists( 'imagejpeg' ) ) {
-            $this->fail( 'jpeg support unavailable' );
-        }
-
         update_option( 'medium_size_w', 400 );
         update_option( 'medium_size_h', 0 );
@@ -165 +163 @@
     }
 
-
+    /**
+     * @requires function imagejpeg
+     */
     function test_insert_image_delete() {
-        if ( ! function_exists( 'imagejpeg' ) ) {
-            $this->fail( 'jpeg support unavailable' );
-        }
-
         update_option( 'medium_size_w', 400 );
         update_option( 'medium_size_h', 0 );