Changeset 49025 for trunk/tests/phpunit/tests/image/functions.php

Timestamp:

09/21/2020 01:25:38 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Convert a few more function_exists() and extension_loaded() checks to @requires annotations.

This better utilizes the PHPUnit native functionality.

Follow-up to [49024].

See #50639, #50640.

File:

• trunk/tests/phpunit/tests/image/functions.php (modified) (5 diffs)

trunk/tests/phpunit/tests/image/functions.php

@@ -150 +150 @@
      *
      * @ticket 6821
+     * @requires extension fileinfo
      */
     public function test_wp_save_image_file() {
-        if ( ! extension_loaded( 'fileinfo' ) ) {
-            $this->markTestSkipped( 'The fileinfo PHP extension is not loaded.' );
-        }
-
         $classes = array( 'WP_Image_Editor_GD', 'WP_Image_Editor_Imagick' );
 
@@ -209 +206 @@
      *
      * @ticket 6821
+     * @requires extension fileinfo
      */
     public function test_mime_overrides_filename() {
-        if ( ! extension_loaded( 'fileinfo' ) ) {
-            $this->markTestSkipped( 'The fileinfo PHP extension is not loaded.' );
-        }
-
         $classes = array( 'WP_Image_Editor_GD', 'WP_Image_Editor_Imagick' );
 
@@ -254 +248 @@
      *
      * @ticket 6821
+     * @requires extension fileinfo
      */
     public function test_inferred_mime_types() {
-        if ( ! extension_loaded( 'fileinfo' ) ) {
-            $this->markTestSkipped( 'The fileinfo PHP extension is not loaded.' );
-        }
-
         $classes = array( 'WP_Image_Editor_GD', 'WP_Image_Editor_Imagick' );
 
@@ -374 +365 @@
     /**
      * @requires function imagejpeg
+     * @requires extension openssl
      */
     public function test_wp_crop_image_url() {
-        if ( ! extension_loaded( 'openssl' ) ) {
-            $this->markTestSkipped( 'Tests_Image_Functions::test_wp_crop_image_url() requires openssl.' );
-        }
-
         $file = wp_crop_image(
             'https://asdftestblog1.files.wordpress.com/2008/04/canola.jpg',
@@ -419 +407 @@
     }
 
+    /**
+     * @requires extension openssl
+     */
     public function test_wp_crop_image_url_not_exist() {
-        if ( ! extension_loaded( 'openssl' ) ) {
-            $this->markTestSkipped( 'Tests_Image_Functions::test_wp_crop_image_url_not_exist() requires openssl.' );
-        }
-
         $file = wp_crop_image(
             'https://asdftestblog1.files.wordpress.com/2008/04/canoladoesnotexist.jpg',