Changeset 49033

Timestamp:

09/22/2020 12:32:39 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use consistent trailing punctuation in fail() messages.

See #51344.

Location:

trunk/tests/phpunit/tests

Files:

• db.php (modified) (1 diff)
• http/base.php (modified) (1 diff)
• image/resize.php (modified) (2 diffs)
• import/parser.php (modified) (2 diffs)
• theme.php (modified) (1 diff)

trunk/tests/phpunit/tests/db.php

@@ -731 +731 @@
                 if ( count( $wpdb->get_results( 'SHOW CREATE PROCEDURE `test_mysqli_flush_sync_procedure`' ) ) < 1 ) {
                         $wpdb->suppress_errors( $suppress );
-                        $this->fail( 'procedure could not be created (missing privileges?)' );
+                        $this->fail( 'Procedure could not be created (missing privileges?)' );
                 }
 

trunk/tests/phpunit/tests/http/base.php

@@ -436 +436 @@
         function test_ssl() {
                 if ( ! wp_http_supports( array( 'ssl' ) ) ) {
-                        $this->fail( 'This installation of PHP does not support SSL' );
+                        $this->fail( 'This installation of PHP does not support SSL.' );
                 }
 

trunk/tests/phpunit/tests/image/resize.php

@@ -43 +43 @@
 
                 if ( ! is_string( $image ) ) {  // WP_Error, stop GLib-GObject-CRITICAL assertion.
-                        $this->fail( sprintf( 'No PNG support in the editor engine %s on this system', $this->editor_engine ) );
+                        $this->fail( sprintf( 'No PNG support in the editor engine %s on this system.', $this->editor_engine ) );
                 }
 
@@ -59 +59 @@
 
                 if ( ! is_string( $image ) ) {  // WP_Error, stop GLib-GObject-CRITICAL assertion.
-                        $this->fail( sprintf( 'No GIF support in the editor engine %s on this system', $this->editor_engine ) );
+                        $this->fail( sprintf( 'No GIF support in the editor engine %s on this system.', $this->editor_engine ) );
                 }
 

trunk/tests/phpunit/tests/import/parser.php

@@ -260 +260 @@
                                                 break;
                                         default:
-                                                $this->fail( 'Unknown postmeta (' . $meta['key'] . ') was parsed out by' . $p );
+                                                $this->fail( sprintf( 'Unknown postmeta (%1$s) was parsed out by %2$s.', $meta['key'], $p ) );
                                 }
                                 $this->assertSame( $value, $meta['value'], $message );
@@ -291 +291 @@
                                         break;
                                 default:
-                                        $this->fail( 'Unknown postmeta (' . $meta['key'] . ') was parsed out by' . $p );
+                                        $this->fail( sprintf( 'Unknown postmeta (%1$s) was parsed out by %2$s.', $meta['key'], $p ) );
                         }
                         $this->assertSame( $value, $meta['value'] );

trunk/tests/phpunit/tests/theme.php

@@ -198 +198 @@
                 $latest_default_theme = WP_Theme::get_core_default_theme();
                 if ( ! $latest_default_theme->exists() || 'twenty' !== substr( $latest_default_theme->get_stylesheet(), 0, 6 ) ) {
-                        $this->fail( 'No Twenty* series default themes are installed' );
+                        $this->fail( 'No Twenty* series default themes are installed.' );
                 }
                 $this->assertContains( $latest_default_theme->get_stylesheet(), $this->default_themes );