Changeset 49046 for trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

Timestamp:

09/25/2020 02:09:32 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correct the check for image sizes in some REST API attachments controller tests.

If the sizes data could not be retrieved, the controller returns an empty object instead of an array.

This makes sure that the value is in fact an array before proceeding, and outputs a proper message in case of failure, instead of an obscure PHP error further in the test.

Follow-up to [49044].

See #50913, #51393.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -605 +605 @@
         remove_image_size( 'rest-api-test' );
 
-        $this->assertNotEmpty( $data['media_details']['sizes'] );
+        $this->assertInternalType( 'array', $data['media_details']['sizes'], 'Could not retrieve the sizes data.' );
         $this->assertSame( $image_src[0], $data['media_details']['sizes']['rest-api-test']['source_url'] );
         $this->assertSame( 'image/jpeg', $data['media_details']['sizes']['rest-api-test']['mime_type'] );
@@ -634 +634 @@
         remove_image_size( 'rest-api-test' );
 
-        $this->assertNotEmpty( $data['media_details']['sizes'] );
+        $this->assertInternalType( 'array', $data['media_details']['sizes'], 'Could not retrieve the sizes data.' );
         $this->assertFalse( isset( $data['media_details']['sizes']['rest-api-test']['source_url'] ) );
     }