Changeset 49062

Timestamp:

09/27/2020 08:48:05 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Media: Check if the item is defined before setting the skipHistory property in media frame router.

This avoids a JS error when refreshing the "Attachment details" modal for an item that is not currently queried.

Follow-up to [41021].

Props Mista-Flo, mukesh27.
Fixes #51395.

File:

• trunk/src/js/media/routers/manage.js (modified) (1 diff)

trunk/src/js/media/routers/manage.js

@@ -44 +44 @@
         // Trigger the media frame to open the correct item.
         item = library.findWhere( { id: parseInt( query, 10 ) } );
-        item.set( 'skipHistory', true );
 
         if ( item ) {
+            item.set( 'skipHistory', true );
             frame.trigger( 'edit:attachment', item );
         } else {