Changeset 49064

Timestamp:

09/27/2020 08:46:44 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Media: Make the "Copy URL" button implementation more consistent with other instances in core:

• Make the "Copied!" text green.
• Make the button verbiage clear that it's copied "to clipboard".

Props garrett-eclipse, mukesh27.
Fixes #51355.

Location:

trunk/src

Files:

• wp-admin/css/media.css (modified) (1 diff)
• wp-admin/includes/media.php (modified) (1 diff)
• wp-includes/css/media-views.css (modified) (1 diff)
• wp-includes/media-template.php (modified) (2 diffs)

trunk/src/wp-admin/css/media.css

@@ -805 +805 @@
 }
 
+.copy-to-clipboard-container .copy-attachment-url {
+    white-space: normal;
+}
+
 .copy-to-clipboard-container .success {
+    color: #40860a;
     margin-left: 8px;
 }

trunk/src/wp-admin/includes/media.php

@@ -3272 +3272 @@
         <input type="text" class="widefat urlfield" readonly="readonly" name="attachment_url" id="attachment_url" value="<?php echo esc_attr( $att_url ); ?>" />
         <span class="copy-to-clipboard-container">
-            <button type="button" class="button copy-attachment-url edit-media" data-clipboard-target="#attachment_url"><?php _e( 'Copy URL' ); ?></button>
+            <button type="button" class="button copy-attachment-url edit-media" data-clipboard-target="#attachment_url"><?php _e( 'Copy URL to clipboard' ); ?></button>
             <span class="success hidden" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>
         </span>

trunk/src/wp-includes/css/media-views.css

@@ -475 +475 @@
     padding: 0;
     min-height: 0;
+    line-height: 2.18181818;
     text-align: left;
+    color: #40860a;
 }
 

trunk/src/wp-includes/media-template.php

@@ -504 +504 @@
                     <input type="text" class="attachment-details-copy-link" id="attachment-details-two-column-copy-link" value="{{ data.url }}" readonly />
                     <span class="copy-to-clipboard-container">
-                        <button type="button" class="button button-small copy-attachment-url" data-clipboard-target="#attachment-details-two-column-copy-link"><?php _e( 'Copy URL' ); ?></button>
+                        <button type="button" class="button button-small copy-attachment-url" data-clipboard-target="#attachment-details-two-column-copy-link"><?php _e( 'Copy URL to clipboard' ); ?></button>
                         <span class="success hidden" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>
                     </span>
@@ -695 +695 @@
             <input type="text" class="attachment-details-copy-link" id="attachment-details-copy-link" value="{{ data.url }}" readonly />
             <div class="copy-to-clipboard-container">
-                <button type="button" class="button button-small copy-attachment-url" data-clipboard-target="#attachment-details-copy-link"><?php _e( 'Copy URL' ); ?></button>
+                <button type="button" class="button button-small copy-attachment-url" data-clipboard-target="#attachment-details-copy-link"><?php _e( 'Copy URL to clipboard' ); ?></button>
                 <span class="success hidden" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>
             </div>