Changeset 49073

Timestamp:

09/30/2020 12:18:36 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Check if the file to retrieve metadata from in get_file_data() was successfully opened.

This avoids a fatal error on PHP 8 caused by passing a false value to fread(), instead of a file resource.

See #50913.

File:

• trunk/src/wp-includes/functions.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -6041 +6041 @@
         $fp = fopen( $file, 'r' );
 
-        // Pull only the first 8 KB of the file in.
-        $file_data = fread( $fp, 8 * KB_IN_BYTES );
-
-        // PHP will close file handle, but we are good citizens.
-        fclose( $fp );
+        if ( $fp ) {
+                // Pull only the first 8 KB of the file in.
+                $file_data = fread( $fp, 8 * KB_IN_BYTES );
+
+                // PHP will close file handle, but we are good citizens.
+                fclose( $fp );
+        } else {
+                $file_data = '';
+        }
 
         // Make sure we catch CR-only line endings.