Changeset 49084

Timestamp:

10/01/2020 05:53:38 PM (4 years ago)

Author:

helen

Message:

Media: Don't unnecessarily check for a valid attachment before getting meta.

This makes wp_get_attachment_metadata() run significantly faster. See ticket for benchmarking.

Props Tkama, donmhico.
Fixes #50679.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (2 diffs)
• tests/phpunit/tests/media.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -5993 +5993 @@
     $attachment_id = (int) $attachment_id;
 
-    $post = get_post( $attachment_id );
-    if ( ! $post ) {
+    $data = get_post_meta( $attachment_id, '_wp_attachment_metadata', true );
+
+    if ( empty( $data ) ) {
         return false;
     }
-
-    $data = get_post_meta( $post->ID, '_wp_attachment_metadata', true );
 
     if ( $unfiltered ) {
@@ -6013 +6012 @@
      * @param int        $attachment_id Attachment post ID.
      */
-    return apply_filters( 'wp_get_attachment_metadata', $data, $post->ID );
+    return apply_filters( 'wp_get_attachment_metadata', $data, $attachment_id );
 }
 

trunk/tests/phpunit/tests/media.php

@@ -2389 +2389 @@
 
     /**
+     * @ticket 50679
+     */
+    function test_wp_get_attachment_metadata_should_return_false_if_no_attachment() {
+        $post_id = self::factory()->post->create();
+        $data   = wp_get_attachment_metadata( $post_id );
+        $this->assertFalse( $data );
+    }
+
+    /**
      * @ticket 37813
      */