Changeset 49084 for trunk/tests/phpunit/tests/media.php

Timestamp:

10/01/2020 05:53:38 PM (3 years ago)

Author:

helen

Message:

Media: Don't unnecessarily check for a valid attachment before getting meta.

This makes wp_get_attachment_metadata() run significantly faster. See ticket for benchmarking.

Props Tkama, donmhico.
Fixes #50679.

File:

• trunk/tests/phpunit/tests/media.php (modified) (1 diff)

trunk/tests/phpunit/tests/media.php

@@ -2389 +2389 @@
 
     /**
+     * @ticket 50679
+     */
+    function test_wp_get_attachment_metadata_should_return_false_if_no_attachment() {
+        $post_id = self::factory()->post->create();
+        $data   = wp_get_attachment_metadata( $post_id );
+        $this->assertFalse( $data );
+    }
+
+    /**
      * @ticket 37813
      */