Changeset 49086

Timestamp:

10/02/2020 12:35:34 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Make checks for an empty post in wp-includes/post.php more consistent.

See #50767.

File:

• trunk/src/wp-includes/post.php (modified) (23 diffs)

trunk/src/wp-includes/post.php

@@ -3191 +3191 @@
      */
     $check = apply_filters( 'pre_trash_post', null, $post );
+
     if ( null !== $check ) {
         return $check;
@@ -3317 +3318 @@
 
     $post = get_post( $post );
-    if ( empty( $post ) ) {
+
+    if ( ! $post ) {
         return;
     }
@@ -3333 +3335 @@
 
     $comments = $wpdb->get_results( $wpdb->prepare( "SELECT comment_ID, comment_approved FROM $wpdb->comments WHERE comment_post_ID = %d", $post_id ) );
-    if ( empty( $comments ) ) {
+
+    if ( ! $comments ) {
         return;
     }
@@ -3376 +3379 @@
 
     $post = get_post( $post );
-    if ( empty( $post ) ) {
+
+    if ( ! $post ) {
         return;
     }
@@ -3384 +3388 @@
     $statuses = get_post_meta( $post_id, '_wp_trash_meta_comments_status', true );
 
-    if ( empty( $statuses ) ) {
+    if ( ! $statuses ) {
         return true;
     }
@@ -4371 +4375 @@
 
     $post = get_post( $post );
+
     if ( ! $post ) {
         return;
@@ -4443 +4448 @@
     $post = get_post( $post_id );
 
-    if ( empty( $post ) ) {
+    if ( ! $post ) {
         return;
     }
@@ -4898 +4903 @@
 
     $post = get_post( $post_id );
+
     if ( ! $post ) {
         return false;
@@ -4974 +4980 @@
 function get_pung( $post_id ) {
     $post = get_post( $post_id );
+
     if ( ! $post ) {
         return false;
@@ -5995 +6002 @@
     $data = get_post_meta( $attachment_id, '_wp_attachment_metadata', true );
 
-    if ( empty( $data ) ) {
+    if ( ! $data ) {
         return false;
     }
@@ -6028 +6035 @@
 
     $post = get_post( $attachment_id );
+
     if ( ! $post ) {
         return false;
@@ -6062 +6070 @@
 
     $post = get_post( $attachment_id );
+
     if ( ! $post ) {
         return false;
@@ -6095 +6104 @@
      * not recommended to rely upon this.
      */
-    if ( empty( $url ) ) {
+    if ( ! $url ) {
         $url = get_the_guid( $post->ID );
     }
@@ -6114 +6123 @@
     $url = apply_filters( 'wp_get_attachment_url', $url, $post->ID );
 
-    if ( empty( $url ) ) {
+    if ( ! $url ) {
         return false;
     }
@@ -6132 +6141 @@
     $post_id = (int) $post_id;
     $post    = get_post( $post_id );
+
     if ( ! $post ) {
         return false;
@@ -6164 +6174 @@
     $post_id = (int) $post_id;
     $post    = get_post( $post_id );
+
     if ( ! $post ) {
         return false;
@@ -6203 +6214 @@
     $post_id = (int) $post_id;
     $post    = get_post( $post_id );
+
     if ( ! $post ) {
         return false;
@@ -6246 +6258 @@
 function wp_attachment_is( $type, $post = null ) {
     $post = get_post( $post );
+
     if ( ! $post ) {
         return false;
@@ -6251 +6264 @@
 
     $file = get_attached_file( $post->ID );
+
     if ( ! $file ) {
         return false;
@@ -6260 +6274 @@
 
     $check = wp_check_filetype( $file );
+
     if ( empty( $check['ext'] ) ) {
         return false;
@@ -6830 +6845 @@
 
     $post = get_post( $post );
-    if ( empty( $post ) ) {
+
+    if ( ! $post ) {
         return;
     }
@@ -7127 +7143 @@
 
     // New post can't cause a loop.
-    if ( empty( $post_ID ) ) {
+    if ( ! $post_ID ) {
         return $post_parent;
     }
@@ -7476 +7492 @@
     $image_url = wp_get_attachment_url( $attachment_id );
 
-    if ( empty( $image_url ) ) {
+    if ( ! $image_url ) {
         return false;
     }