Changeset 49108 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

10/08/2020 09:13:57 PM (5 years ago)

Author:

SergeyBiryukov

Message:

General: Replace older-style PHP type conversion functions with type casts.

This improves performance, readability, and consistency throughout core.

• intval() → (int)
• strval() → (string)
• floatval() → (float)

Props ayeshrajans.
Fixes #42918.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (11 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -228 +228 @@
  */
 function wp_ajax_imgedit_preview() {
-    $post_id = intval( $_GET['postid'] );
+    $post_id = (int) $_GET['postid'];
     if ( empty( $post_id ) || ! current_user_can( 'edit_post', $post_id ) ) {
         wp_die( -1 );
@@ -1955 +1955 @@
 function wp_ajax_get_permalink() {
     check_ajax_referer( 'getpermalink', 'getpermalinknonce' );
-    $post_id = isset( $_POST['post_id'] ) ? intval( $_POST['post_id'] ) : 0;
+    $post_id = isset( $_POST['post_id'] ) ? (int) $_POST['post_id'] : 0;
     wp_die( get_preview_post_link( $post_id ) );
 }
@@ -1966 +1966 @@
 function wp_ajax_sample_permalink() {
     check_ajax_referer( 'samplepermalink', 'samplepermalinknonce' );
-    $post_id = isset( $_POST['post_id'] ) ? intval( $_POST['post_id'] ) : 0;
+    $post_id = isset( $_POST['post_id'] ) ? (int) $_POST['post_id'] : 0;
     $title   = isset( $_POST['new_title'] ) ? $_POST['new_title'] : '';
     $slug    = isset( $_POST['new_slug'] ) ? $_POST['new_slug'] : null;
@@ -2595 +2595 @@
  */
 function wp_ajax_image_editor() {
-    $attachment_id = intval( $_POST['postid'] );
+    $attachment_id = (int) $_POST['postid'];
 
     if ( empty( $attachment_id ) || ! current_user_can( 'edit_post', $attachment_id ) ) {
@@ -2652 +2652 @@
     $json = ! empty( $_REQUEST['json'] ); // New-style request.
 
-    $post_ID = intval( $_POST['post_id'] );
+    $post_ID = (int) $_POST['post_id'];
     if ( ! current_user_can( 'edit_post', $post_ID ) ) {
         wp_die( -1 );
     }
 
-    $thumbnail_id = intval( $_POST['thumbnail_id'] );
+    $thumbnail_id = (int) $_POST['thumbnail_id'];
 
     if ( $json ) {
@@ -2688 +2688 @@
  */
 function wp_ajax_get_post_thumbnail_html() {
-    $post_ID = intval( $_POST['post_id'] );
+    $post_ID = (int) $_POST['post_id'];
 
     check_ajax_referer( "update-post_$post_ID" );
@@ -2696 +2696 @@
     }
 
-    $thumbnail_id = intval( $_POST['thumbnail_id'] );
+    $thumbnail_id = (int) $_POST['thumbnail_id'];
 
     // For backward compatibility, -1 refers to no featured image.
@@ -3209 +3209 @@
     $attachment = wp_unslash( $_POST['attachment'] );
 
-    $id = intval( $attachment['id'] );
+    $id = (int) $attachment['id'];
 
     $post = get_post( $id );
@@ -3222 +3222 @@
     if ( current_user_can( 'edit_post', $id ) ) {
         // If this attachment is unattached, attach it. Primarily a back compat thing.
-        $insert_into_post_id = intval( $_POST['post_id'] );
+        $insert_into_post_id = (int) $_POST['post_id'];
 
         if ( 0 == $post->post_parent && $insert_into_post_id ) {
@@ -3623 +3623 @@
     }
 
-    $post_id = isset( $_POST['post_ID'] ) ? intval( $_POST['post_ID'] ) : 0;
+    $post_id = isset( $_POST['post_ID'] ) ? (int) $_POST['post_ID'] : 0;
 
     if ( $post_id > 0 ) {
@@ -3675 +3675 @@
     if ( isset( $_POST['maxwidth'] ) && is_numeric( $_POST['maxwidth'] ) && $_POST['maxwidth'] > 0 ) {
         if ( ! isset( $content_width ) ) {
-            $content_width = intval( $_POST['maxwidth'] );
+            $content_width = (int) $_POST['maxwidth'];
         } else {
-            $content_width = min( $content_width, intval( $_POST['maxwidth'] ) );
+            $content_width = min( $content_width, (int) $_POST['maxwidth'] );
         }
     }