Changeset 49108 for trunk/src/wp-admin/includes/media.php

Timestamp:

10/08/2020 09:13:57 PM (4 years ago)

Author:

SergeyBiryukov

Message:

General: Replace older-style PHP type conversion functions with type casts.

This improves performance, readability, and consistency throughout core.

• intval() → (int)
• strval() → (string)
• floatval() → (float)

Props ayeshrajans.
Fixes #42918.

File:

• trunk/src/wp-admin/includes/media.php (modified) (12 diffs)

trunk/src/wp-admin/includes/media.php

@@ -50 +50 @@
     }
 
-    $post_id = intval( $_REQUEST['post_id'] );
+    $post_id = (int) $_REQUEST['post_id'];
 
     if ( $post_id ) {
-        $attachments = intval( $wpdb->get_var( $wpdb->prepare( "SELECT count(*) FROM $wpdb->posts WHERE post_type = 'attachment' AND post_status != 'trash' AND post_parent = %d", $post_id ) ) );
+        $attachments = (int) $wpdb->get_var( $wpdb->prepare( "SELECT count(*) FROM $wpdb->posts WHERE post_type = 'attachment' AND post_status != 'trash' AND post_parent = %d", $post_id ) );
     }
 
@@ -139 +139 @@
             $rel = ' rel="' . esc_attr( $rel ) . '"';
         } else {
-            $rel = ' rel="attachment wp-att-' . intval( $id ) . '"';
+            $rel = ' rel="attachment wp-att-' . (int) $id . '"';
         }
     } else {
@@ -1550 +1550 @@
 
     $thumb_url     = false;
-    $attachment_id = intval( $attachment_id );
+    $attachment_id = (int) $attachment_id;
 
     if ( $attachment_id ) {
@@ -2036 +2036 @@
  */
 function media_upload_header() {
-    $post_id = isset( $_REQUEST['post_id'] ) ? intval( $_REQUEST['post_id'] ) : 0;
+    $post_id = isset( $_REQUEST['post_id'] ) ? (int) $_REQUEST['post_id'] : 0;
 
     echo '<script type="text/javascript">post_id = ' . $post_id . ';</script>';
@@ -2072 +2072 @@
 
     $upload_action_url = admin_url( 'async-upload.php' );
-    $post_id           = isset( $_REQUEST['post_id'] ) ? intval( $_REQUEST['post_id'] ) : 0;
+    $post_id           = isset( $_REQUEST['post_id'] ) ? (int) $_REQUEST['post_id'] : 0;
     $_type             = isset( $type ) ? $type : '';
     $_tab              = isset( $tab ) ? $tab : '';
@@ -2282 +2282 @@
     media_upload_header();
 
-    $post_id = isset( $_REQUEST['post_id'] ) ? intval( $_REQUEST['post_id'] ) : 0;
+    $post_id = isset( $_REQUEST['post_id'] ) ? (int) $_REQUEST['post_id'] : 0;
 
     $form_action_url = admin_url( "media-upload.php?type=$type&tab=type&post_id=$post_id" );
@@ -2359 +2359 @@
     media_upload_header();
 
-    $post_id = isset( $_REQUEST['post_id'] ) ? intval( $_REQUEST['post_id'] ) : 0;
+    $post_id = isset( $_REQUEST['post_id'] ) ? (int) $_REQUEST['post_id'] : 0;
 
     $form_action_url = admin_url( "media-upload.php?type=$type&tab=type&post_id=$post_id" );
@@ -2507 +2507 @@
     media_upload_header();
 
-    $post_id         = intval( $_REQUEST['post_id'] );
+    $post_id         = (int) $_REQUEST['post_id'];
     $form_action_url = admin_url( "media-upload.php?type=$type&tab=gallery&post_id=$post_id" );
     /** This filter is documented in wp-admin/includes/media.php */
@@ -2670 +2670 @@
     media_upload_header();
 
-    $post_id = isset( $_REQUEST['post_id'] ) ? intval( $_REQUEST['post_id'] ) : 0;
+    $post_id = isset( $_REQUEST['post_id'] ) ? (int) $_REQUEST['post_id'] : 0;
 
     $form_action_url = admin_url( "media-upload.php?type=$type&tab=library&post_id=$post_id" );
@@ -2683 +2683 @@
     $q                   = $_GET;
     $q['posts_per_page'] = 10;
-    $q['paged']          = isset( $q['paged'] ) ? intval( $q['paged'] ) : 0;
+    $q['paged']          = isset( $q['paged'] ) ? (int) $q['paged'] : 0;
     if ( $q['paged'] < 1 ) {
         $q['paged'] = 1;
@@ -2985 +2985 @@
     $post = get_post();
     if ( $post ) {
-        $browser_uploader .= '&amp;post_id=' . intval( $post->ID );
+        $browser_uploader .= '&amp;post_id=' . (int) $post->ID;
     } elseif ( ! empty( $GLOBALS['post_ID'] ) ) {
-        $browser_uploader .= '&amp;post_id=' . intval( $GLOBALS['post_ID'] );
+        $browser_uploader .= '&amp;post_id=' . (int) $GLOBALS['post_ID'];
     }
 
@@ -3079 +3079 @@
 
     $thumb_url     = false;
-    $attachment_id = intval( $post->ID );
+    $attachment_id = (int) $post->ID;
 
     if ( $attachment_id ) {