Changeset 49108 for trunk/src/wp-admin/includes/plugin.php

Timestamp:

10/08/2020 09:13:57 PM (4 years ago)

Author:

SergeyBiryukov

Message:

General: Replace older-style PHP type conversion functions with type casts.

This improves performance, readability, and consistency throughout core.

• intval() → (int)
• strval() → (string)
• floatval() → (float)

Props ayeshrajans.
Fixes #42918.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (1 diff)

trunk/src/wp-admin/includes/plugin.php

@@ -1348 +1348 @@
     if ( null === $position ) {
         $menu[] = $new_menu;
-    } elseif ( isset( $menu[ "$position" ] ) ) {
-        $position            = $position + substr( base_convert( md5( $menu_slug . $menu_title ), 16, 10 ), -5 ) * 0.00001;
-        $menu[ "$position" ] = $new_menu;
     } else {
+        if ( isset( $menu[ $position ] ) ) {
+            $position = $position + substr( base_convert( md5( $menu_slug . $menu_title ), 16, 10 ), -5 ) * 0.00001;
+        }
+
         $menu[ $position ] = $new_menu;
     }