Changeset 49108 for trunk/src/wp-includes/class-wp-xmlrpc-server.php

Timestamp:

10/08/2020 09:13:57 PM (6 years ago)

Author:

SergeyBiryukov

Message:

General: Replace older-style PHP type conversion functions with type casts.

This improves performance, readability, and consistency throughout core.

• intval() → (int)
• strval() → (string)
• floatval() → (float)

Props ayeshrajans.
Fixes #42918.

File:

• trunk/src/wp-includes/class-wp-xmlrpc-server.php (modified) (10 diffs)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -799 +799 @@
 
                 // For integers which may be larger than XML-RPC supports ensure we return strings.
-                $_term['term_id']          = strval( $_term['term_id'] );
-                $_term['term_group']       = strval( $_term['term_group'] );
-                $_term['term_taxonomy_id'] = strval( $_term['term_taxonomy_id'] );
-                $_term['parent']           = strval( $_term['parent'] );
+                $_term['term_id']          = (string) $_term['term_id'];
+                $_term['term_group']       = (string) $_term['term_group'];
+                $_term['term_taxonomy_id'] = (string) $_term['term_taxonomy_id'];
+                $_term['parent']           = (string) $_term['parent'];
 
                 // Count we are happy to return as an integer because people really shouldn't use terms that much.
-                $_term['count'] = intval( $_term['count'] );
+                $_term['count'] = (int) $_term['count'];
 
                 // Get term meta.
@@ -857 +857 @@
         protected function _prepare_post( $post, $fields ) {
                 // Holds the data for this post. built up based on $fields.
-                $_post = array( 'post_id' => strval( $post['ID'] ) );
+                $_post = array( 'post_id' => (string) $post['ID'] );
 
                 // Prepare common post fields.
@@ -873 +873 @@
                         'post_excerpt'      => $post['post_excerpt'],
                         'post_content'      => $post['post_content'],
-                        'post_parent'       => strval( $post['post_parent'] ),
+                        'post_parent'       => (string) $post['post_parent'],
                         'post_mime_type'    => $post['post_mime_type'],
                         'link'              => get_permalink( $post['ID'] ),
                         'guid'              => $post['guid'],
-                        'menu_order'        => intval( $post['menu_order'] ),
+                        'menu_order'        => (int) $post['menu_order'],
                         'comment_status'    => $post['comment_status'],
                         'ping_status'       => $post['ping_status'],
@@ -1010 +1010 @@
         protected function _prepare_media_item( $media_item, $thumbnail_size = 'thumbnail' ) {
                 $_media_item = array(
-                        'attachment_id'    => strval( $media_item->ID ),
+                        'attachment_id'    => (string) $media_item->ID,
                         'date_created_gmt' => $this->_convert_date_gmt( $media_item->post_date_gmt, $media_item->post_date ),
                         'parent'           => $media_item->post_parent,
@@ -1175 +1175 @@
          */
         protected function _prepare_user( $user, $fields ) {
-                $_user = array( 'user_id' => strval( $user->ID ) );
+                $_user = array( 'user_id' => (string) $user->ID );
 
                 $user_fields = array(
@@ -1648 +1648 @@
                 }
 
-                return strval( $post_ID );
+                return (string) $post_ID;
         }
 
@@ -2095 +2095 @@
                 }
 
-                return strval( $term['term_id'] );
+                return (string) $term['term_id'];
         }
 
@@ -5567 +5567 @@
                 do_action( 'xmlrpc_call_success_mw_newPost', $post_ID, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 
-                return strval( $post_ID );
+                return (string) $post_ID;
         }
 
@@ -6556 +6556 @@
 
                 $categories = array();
-                $catids     = wp_get_post_categories( intval( $post_ID ) );
+                $catids     = wp_get_post_categories( (int) $post_ID );
                 // First listed category will be the primary category.
                 $isPrimary = true;
@@ -6813 +6813 @@
                 } elseif ( isset( $urltest['fragment'] ) ) {
                         // An #anchor is there, it's either...
-                        if ( intval( $urltest['fragment'] ) ) {
+                        if ( (int) $urltest['fragment'] ) {
                                 // ...an integer #XXXX (simplest case),
                                 $post_ID = (int) $urltest['fragment'];