Changeset 49108 for trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php

Timestamp:

10/08/2020 09:13:57 PM (4 years ago)

Author:

SergeyBiryukov

Message:

General: Replace older-style PHP type conversion functions with type casts.

This improves performance, readability, and consistency throughout core.

• intval() → (int)
• strval() → (string)
• floatval() → (float)

Props ayeshrajans.
Fixes #42918.

File:

• trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php (modified) (5 diffs)

trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php

@@ -172 +172 @@
         }
 
-        $this->post_id = intval( $matches['id'] );
+        $this->post_id = (int) $matches['id'];
         add_action( 'wp_update_nav_menu_item', array( $this, 'flush_cached_value' ), 10, 2 );
 
@@ -369 +369 @@
         foreach ( array( 'object_id', 'menu_item_parent', 'nav_menu_term_id' ) as $key ) {
             if ( ! is_int( $this->value[ $key ] ) ) {
-                $this->value[ $key ] = intval( $this->value[ $key ] );
+                $this->value[ $key ] = (int) $this->value[ $key ];
             }
         }
@@ -685 +685 @@
         $menu_item_value             = array_merge( $default, $menu_item_value );
         $menu_item_value             = wp_array_slice_assoc( $menu_item_value, array_keys( $default ) );
-        $menu_item_value['position'] = intval( $menu_item_value['position'] );
+        $menu_item_value['position'] = (int) $menu_item_value['position'];
 
         foreach ( array( 'object_id', 'menu_item_parent', 'nav_menu_term_id' ) as $key ) {
             // Note we need to allow negative-integer IDs for previewed objects not inserted yet.
-            $menu_item_value[ $key ] = intval( $menu_item_value[ $key ] );
+            $menu_item_value[ $key ] = (int) $menu_item_value[ $key ];
         }
 
@@ -799 +799 @@
                 }
 
-                if ( intval( $value['nav_menu_term_id'] ) !== $nav_menu_setting->previous_term_id ) {
+                if ( (int) $value['nav_menu_term_id'] !== $nav_menu_setting->previous_term_id ) {
                     $this->update_status = 'error';
                     $this->update_error  = new WP_Error( 'unexpected_previous_term_id' );
@@ -825 +825 @@
                 }
 
-                if ( intval( $value['menu_item_parent'] ) !== $parent_nav_menu_item_setting->previous_post_id ) {
+                if ( (int) $value['menu_item_parent'] !== $parent_nav_menu_item_setting->previous_post_id ) {
                     $this->update_status = 'error';
                     $this->update_error  = new WP_Error( 'unexpected_previous_post_id' );