Changeset 49108 for trunk/src/wp-includes/customize/class-wp-customize-nav-menu-setting.php

Timestamp:

10/08/2020 09:13:57 PM (4 years ago)

Author:

SergeyBiryukov

Message:

General: Replace older-style PHP type conversion functions with type casts.

This improves performance, readability, and consistency throughout core.

• intval() → (int)
• strval() → (string)
• floatval() → (float)

Props ayeshrajans.
Fixes #42918.

File:

• trunk/src/wp-includes/customize/class-wp-customize-nav-menu-setting.php (modified) (4 diffs)

trunk/src/wp-includes/customize/class-wp-customize-nav-menu-setting.php

@@ -142 +142 @@
         }
 
-        $this->term_id = intval( $matches['id'] );
+        $this->term_id = (int) $matches['id'];
 
         parent::__construct( $manager, $id, $args );
@@ -434 +434 @@
         $value['name']        = trim( esc_html( $value['name'] ) ); // This sanitization code is used in wp-admin/nav-menus.php.
         $value['description'] = sanitize_text_field( $value['description'] );
-        $value['parent']      = max( 0, intval( $value['parent'] ) );
+        $value['parent']      = max( 0, (int) $value['parent'] );
         $value['auto_add']    = ! empty( $value['auto_add'] );
 
@@ -557 +557 @@
 
                 $post_value = $setting->post_value( null );
-                if ( ! is_null( $post_value ) && intval( $post_value ) === $this->previous_term_id ) {
+                if ( ! is_null( $post_value ) && (int) $post_value === $this->previous_term_id ) {
                     $this->manager->set_post_value( $setting->id, $this->term_id );
                     $setting->save();
@@ -571 +571 @@
 
                 $widget_instance = $nav_menu_widget_setting->post_value(); // Note that this calls WP_Customize_Widgets::sanitize_widget_instance().
-                if ( empty( $widget_instance['nav_menu'] ) || intval( $widget_instance['nav_menu'] ) !== $this->previous_term_id ) {
+                if ( empty( $widget_instance['nav_menu'] ) || (int) $widget_instance['nav_menu'] !== $this->previous_term_id ) {
                     continue;
                 }