Changeset 49108 for trunk/src/wp-includes/widgets/class-wp-widget-links.php

Timestamp:

10/08/2020 09:13:57 PM (4 years ago)

Author:

SergeyBiryukov

Message:

General: Replace older-style PHP type conversion functions with type casts.

This improves performance, readability, and consistency throughout core.

• intval() → (int)
• strval() → (string)
• floatval() → (float)

Props ayeshrajans.
Fixes #42918.

File:

• trunk/src/wp-includes/widgets/class-wp-widget-links.php (modified) (4 diffs)

trunk/src/wp-includes/widgets/class-wp-widget-links.php

@@ -110 +110 @@
         }
 
-        $instance['category'] = intval( $new_instance['category'] );
-        $instance['limit']    = ! empty( $new_instance['limit'] ) ? intval( $new_instance['limit'] ) : -1;
+        $instance['category'] = (int) $new_instance['category'];
+        $instance['limit']    = ! empty( $new_instance['limit'] ) ? (int) $new_instance['limit'] : -1;
 
         return $instance;
@@ -139 +139 @@
         );
         $link_cats = get_terms( array( 'taxonomy' => 'link_category' ) );
-        $limit     = intval( $instance['limit'] );
+        $limit     = (int) $instance['limit'];
         if ( ! $limit ) {
             $limit = -1;
@@ -149 +149 @@
                 <option value=""><?php _ex( 'All Links', 'links widget' ); ?></option>
                 <?php foreach ( $link_cats as $link_cat ) : ?>
-                    <option value="<?php echo intval( $link_cat->term_id ); ?>" <?php selected( $instance['category'], $link_cat->term_id ); ?>>
+                    <option value="<?php echo (int) $link_cat->term_id; ?>" <?php selected( $instance['category'], $link_cat->term_id ); ?>>
                         <?php echo esc_html( $link_cat->name ); ?>
                     </option>
@@ -182 +182 @@
         <p>
             <label for="<?php echo $this->get_field_id( 'limit' ); ?>"><?php _e( 'Number of links to show:' ); ?></label>
-            <input id="<?php echo $this->get_field_id( 'limit' ); ?>" name="<?php echo $this->get_field_name( 'limit' ); ?>" type="text" value="<?php echo ( -1 !== $limit ) ? intval( $limit ) : ''; ?>" size="3" />
+            <input id="<?php echo $this->get_field_id( 'limit' ); ?>" name="<?php echo $this->get_field_name( 'limit' ); ?>" type="text" value="<?php echo ( -1 !== $limit ) ? (int) $limit : ''; ?>" size="3" />
         </p>
         <?php