Changeset 49125 for trunk/src/wp-admin/edit.php

Timestamp:

10/11/2020 01:37:04 PM (19 months ago)

Author:

johnbillion

Message:

Posts, Post Types: Switch to restoring posts to draft status by default when they are untrashed.

This allows for edits to be made to a restored post before it goes live again. This also prevents scheduled posts being published unexpectedly if they are untrashed after their originally scheduled date.

The old behaviour of restoring untrashed posts to their original status can be reinstated using the wp_untrash_post_set_previous_status() helper function.

Also fixes an issue where the incorrect post ID gets passed to hooks if no post ID is passed to the function.

Props harrym, bananastalktome, jaredcobb, chriscct7, melchoyce, johnbillion, pankajmohale

Fixes #23022

File:

• trunk/src/wp-admin/edit.php (modified) (3 diffs)

trunk/src/wp-admin/edit.php

@@ -135 +135 @@
         case 'untrash':
             $untrashed = 0;
+
+            if ( isset( $_GET['doaction'] ) && ( 'undo' === $_GET['doaction'] ) ) {
+                add_filter( 'wp_untrash_post_status', 'wp_untrash_post_set_previous_status', 10, 3 );
+            }
+
             foreach ( (array) $post_ids as $post_id ) {
                 if ( ! current_user_can( 'delete_post', $post_id ) ) {
@@ -147 +152 @@
             }
             $sendback = add_query_arg( 'untrashed', $untrashed, $sendback );
+
+            remove_filter( 'wp_untrash_post_status', 'wp_untrash_post_set_previous_status', 10, 3 );
+
             break;
         case 'delete':
@@ -420 +428 @@
         $messages[] = '<a href="' . esc_url( wp_nonce_url( "edit.php?post_type=$post_type&doaction=undo&action=untrash&ids=$ids", 'bulk-posts' ) ) . '">' . __( 'Undo' ) . '</a>';
     }
+
+    if ( 'untrashed' === $message && isset( $_REQUEST['ids'] ) ) {
+        $ids = explode( ',', $_REQUEST['ids'] );
+
+        if ( 1 === count( $ids ) && current_user_can( 'edit_post', $ids[0] ) ) {
+            $messages[] = sprintf(
+                '<a href="%1$s">%2$s</a>',
+                esc_url( get_edit_post_link( $ids[0] ) ),
+                esc_html( get_post_type_object( get_post_type( $ids[0] ) )->labels->edit_item )
+            );
+        }
+    }
 }