Changeset 49126

Timestamp:

10/11/2020 03:49:30 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in test_edit_user_blank_password(), for consistency with other assertions.

Follow-up to [49118].

See #42766, #38266.

File:

• trunk/tests/phpunit/tests/user.php (modified) (5 diffs)

trunk/tests/phpunit/tests/user.php

@@ -1454 +1454 @@
          * @ticket 42766
          */
-        function test_edit_user_blank_pw() {
+        function test_edit_user_blank_password() {
                 $_POST                 = array();
                 $_GET                  = array();
@@ -1493 +1493 @@
                 $this->assertSame( 'nickname_updated', $user->nickname );
 
-                // Check not to change an old password if a new password contains only spaces. Ticket #42766
+                // Check not to change an old password if a new password contains only spaces. Ticket #42766.
                 $user           = get_user_by( 'ID', $user_id );
                 $old_pass       = $user->user_pass;
@@ -1503 +1503 @@
 
                 $this->assertInternalType( 'int', $user_id );
-                $this->assertEquals( $old_pass, $user->user_pass );
+                $this->assertSame( $old_pass, $user->user_pass );
 
                 // Check updating user with missing second password.
@@ -1517 +1517 @@
 
                 // Check updating user with empty password via `check_passwords` action.
-                add_action( 'check_passwords', array( $this, 'action_check_passwords_blank_pw' ), 10, 2 );
+                add_action( 'check_passwords', array( $this, 'action_check_passwords_blank_password' ), 10, 2 );
                 $user_id = edit_user( $user_id );
-                remove_action( 'check_passwords', array( $this, 'action_check_passwords_blank_pw' ) );
+                remove_action( 'check_passwords', array( $this, 'action_check_passwords_blank_password' ) );
 
                 $this->assertInternalType( 'int', $user_id );
@@ -1526 +1526 @@
 
         /**
-         * Check passwords action for test_edit_user_blank_pw().
-         */
-        function action_check_passwords_blank_pw( $user_login, &$pass1 ) {
+         * Check passwords action for test_edit_user_blank_password().
+         */
+        function action_check_passwords_blank_password( $user_login, &$pass1 ) {
                 $pass1 = '';
         }