Changeset 49128

Timestamp:

10/11/2020 07:59:15 PM (4 years ago)

Author:

johnbillion

Message:

Media: Allow the gallery_shortcode() and get_image_tag() functions to correctly accept an array of image dimensions.

These functions did previously accept an array of image dimensions but their class attributes were not properly constructed.

Fixes #51362

File:

• trunk/src/wp-includes/media.php (modified) (3 diffs)

trunk/src/wp-includes/media.php

@@ -368 +368 @@
  * @param string       $align Part of the class name for aligning the image.
  * @param string|int[] $size  Optional. Image size. Accepts any registered image size name, or an array of
- *                           width and height values in pixels (in that order). Default 'medium'.
+ *                            width and height values in pixels (in that order). Default 'medium'.
  * @return string HTML IMG element for given image attachment
  */
@@ -378 +378 @@
     $title = $title ? 'title="' . esc_attr( $title ) . '" ' : '';
 
-    $class = 'align' . esc_attr( $align ) . ' size-' . esc_attr( $size ) . ' wp-image-' . $id;
+    $size_class = is_array( $size ) ? implode( 'x', $size ) : $size;
+    $class      = 'align' . esc_attr( $align ) . ' size-' . esc_attr( $size_class ) . ' wp-image-' . $id;
 
     /**
@@ -2335 +2336 @@
     }
 
-    $size_class  = sanitize_html_class( $atts['size'] );
+    $size_class  = sanitize_html_class( is_array( $atts['size'] ) ? implode( 'x', $atts['size'] ) : $atts['size'] );
     $gallery_div = "<div id='$selector' class='gallery galleryid-{$id} gallery-columns-{$columns} gallery-size-{$size_class}'>";