Changeset 49138 for trunk/src/wp-admin/includes/plugin.php

Timestamp:

10/13/2020 07:57:10 PM (5 years ago)

Author:

ocean90

Message:

Administration: Restore alternative admin menu position for menu items with the same position value as an existing menu item.

Reverts parts of [49108].

Props johnjamesjacoby.
Fixes #42918.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (1 diff)

trunk/src/wp-admin/includes/plugin.php

@@ -1348 +1348 @@
     if ( null === $position ) {
         $menu[] = $new_menu;
+    } elseif ( isset( $menu[ "$position" ] ) ) {
+        $position            = $position + substr( base_convert( md5( $menu_slug . $menu_title ), 16, 10 ), -5 ) * 0.00001;
+        $menu[ "$position" ] = $new_menu;
     } else {
-        if ( isset( $menu[ $position ] ) ) {
-            $position = $position + substr( base_convert( md5( $menu_slug . $menu_title ), 16, 10 ), -5 ) * 0.00001;
-        }
-
         $menu[ $position ] = $new_menu;
     }