Changeset 49154 for trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php

Timestamp:

10/15/2020 01:58:28 AM (5 years ago)

Author:

TimothyBlynJacobs

Message:

Site Health, REST API: Move async tests to REST API endpoints.

This provides more flexibility when writing tests and benefits from running in a front-end context which is necessary for some tests like checking that updates are supported. Additionally, this provides a more robust interface for developers who want to integrate with Site Health tests.

Because the wp/v2 endpoint is reserved for modeling core entities, site health is registered in its own wp-site-health/v1 namespace.

The existing ajax actions have been maintained for backward compatibility.

Props Clorith, chrisvanpatten, afragen, pokhriyal, TimothyBlynJacobs.
Fixes #48105.

File:

• trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php

@@ -91 +91 @@
      */
     public function test_wp_version_check_attached() {
-        if ( ! is_main_site() ) {
-            return;
-        }
-
-        $cookies = wp_unslash( $_COOKIE );
-        $timeout = 10;
-        $headers = array(
-            'Cache-Control' => 'no-cache',
-        );
-        /** This filter is documented in wp-includes/class-wp-http-streams.php */
-        $sslverify = apply_filters( 'https_local_ssl_verify', false );
-
-        // Include Basic auth in loopback requests.
-        if ( isset( $_SERVER['PHP_AUTH_USER'] ) && isset( $_SERVER['PHP_AUTH_PW'] ) ) {
-            $headers['Authorization'] = 'Basic ' . base64_encode( wp_unslash( $_SERVER['PHP_AUTH_USER'] ) . ':' . wp_unslash( $_SERVER['PHP_AUTH_PW'] ) );
-        }
-
-        $url = add_query_arg(
-            array(
-                'health-check-test-wp_version_check' => true,
-            ),
-            admin_url( 'site-health.php' )
-        );
-
-        $test = wp_remote_get( $url, compact( 'cookies', 'headers', 'timeout', 'sslverify' ) );
-
-        if ( is_wp_error( $test ) ) {
-            return array(
-                'description' => sprintf(
-                    /* translators: %s: Name of the filter used. */
-                    __( 'Could not confirm that the %s filter is available.' ),
-                    '<code>wp_version_check()</code>'
-                ),
-                'severity'    => 'warning',
-            );
-        }
-
-        $response = wp_remote_retrieve_body( $test );
-
-        if ( 'yes' !== $response ) {
+        if ( ! has_filter( 'wp_version_check', 'wp_version_check' ) ) {
             return array(
                 'description' => sprintf(
@@ -311 +272 @@
      */
     function test_check_wp_filesystem_method() {
+        // Make sure the `request_filesystem_credentials` function is available during our REST call.
+        if ( ! function_exists( 'request_filesystem_credentials' ) ) {
+            require_once ABSPATH . '/wp-admin/includes/file.php';
+        }
+
         $skin    = new Automatic_Upgrader_Skin;
         $success = $skin->request_filesystem_credentials( false, ABSPATH );
@@ -355 +321 @@
         if ( 'direct' !== $wp_filesystem->method ) {
             return false;
+        }
+
+        // Make sure the `get_core_checksums` function is available during our REST call.
+        if ( ! function_exists( 'get_core_checksums' ) ) {
+            require_once ABSPATH . '/wp-admin/includes/update.php';
         }