Changeset 49168

Timestamp:

10/16/2020 12:25:18 AM (4 years ago)

Author:

desrosj

Message:

Build/Test Tools: Do not cancel previous workflow runs.

When a workflow is cancelled, it’s marked as a failure. This is not ideal because the commit attached to the workflow run will appear as though it introduced a problem, but this may not be true.

Because GitHub Actions work a bit differently than Travis builds, it’s unlikely that the same bottleneck will be encountered in workflows.

This change removes all workflow job steps that cancel previous workflows.

See #50401.

Location:

trunk/.github/workflows

Files:

• end-to-end-tests.yml (modified) (2 diffs)
• javascript-tests.yml (modified) (2 diffs)
• phpunit-tests.yml (modified) (2 diffs)
• verify-npm-on-windows.yml (modified) (2 diffs)

trunk/.github/workflows/end-to-end-tests.yml

@@ -17 +17 @@
   #
   # Performs the following steps:
-  # - Cancels all previous workflow runs that have not completed.
   # - Set environment variables.
   # - Checks out the repository.
@@ -36 +35 @@
     runs-on: ubuntu-latest
     steps:
-      - name: Cancel previous runs of this workflow
-        uses: styfle/cancel-workflow-action@0.5.0
-        with:
-          access_token: ${{ github.token }}
-
       - name: Configure environment variables
         run: |

trunk/.github/workflows/javascript-tests.yml

@@ -12 +12 @@
   #
   # Performs the following steps:
-  # - Cancels all previous workflow runs that have not completed.
   # - Checks out the repository.
   # - Logs debug information about the runner container.
@@ -25 +24 @@
     runs-on: ubuntu-latest
     steps:
-      - name: Cancel previous runs of this workflow
-        uses: styfle/cancel-workflow-action@0.5.0
-        with:
-          access_token: ${{ github.token }}
-
       - name: Checkout repository
         uses: actions/checkout@v2

trunk/.github/workflows/phpunit-tests.yml

@@ -23 +23 @@
   #
   # Performs the following steps:
-  # - Cancels all previous workflow runs that have not completed.
   # - Checks out the repository.
   # - Checks out the WordPress Importer plugin (needed for the Core PHPUnit tests).
@@ -38 +37 @@
 
     steps:
-      - name: Cancel previous runs of this workflow
-        uses: styfle/cancel-workflow-action@0.5.0
-        with:
-          access_token: ${{ github.token }}
-
       - name: Checkout repository
         uses: actions/checkout@v2

trunk/.github/workflows/verify-npm-on-windows.yml

@@ -12 +12 @@
   #
   # Performs the following steps:
-  # - Cancels all previous workflow runs that have not completed.
   # - Checks out the repository.
   # - Logs debug information about the runner container.
@@ -23 +22 @@
     runs-on: windows-latest
     steps:
-      - name: Cancel previous runs of this workflow
-        uses: styfle/cancel-workflow-action@0.5.0
-        with:
-          access_token: ${{ github.token }}
-
       - name: Checkout repository
         uses: actions/checkout@v2