Changeset 49171 for trunk/src/wp-includes/class-wp-taxonomy.php

Timestamp:

10/16/2020 02:41:15 AM (4 years ago)

Author:

peterwilsoncc

Message:

Taxonomy: Fix warnings thrown by custom term count callbacks.

Add a use to a closure to avoid an undefined variable throwing a warning. Adds unit tests to ensure the custom callbacks run as expected when defined.

Follow up to [49141].
Props ocean90, dd32.
Fixes #40351.

File:

• trunk/src/wp-includes/class-wp-taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-taxonomy.php

@@ -427 +427 @@
             empty( $args['update_count_by_callback'] )
         ) {
-            $args['update_count_by_callback'] = function( $tt_ids, $taxonomy, $modify_by ) {
+            $args['update_count_by_callback'] = function( $tt_ids, $taxonomy ) use ( $args ) {
                 return call_user_func( $args['update_count_callback'], $tt_ids, $taxonomy );
             };