Changeset 49186

Timestamp:

10/18/2020 06:27:38 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove unnecessary reference sign from PO::export_entry() definition.

This fixes a PHP 8 "argument must be passed by reference, value given" error when using array_map() in PO::export_entries().

Object variables in PHP 5+ contain a reference to the object, and it's the reference that's passed around.

Props jrf.
See #50913.

File:

• trunk/src/wp-includes/pomo/po.php (modified) (1 diff)

trunk/src/wp-includes/pomo/po.php

@@ -213 +213 @@
          * Builds a string from the entry for inclusion in PO file
          *
-         * @param Translation_Entry $entry the entry to convert to po string (passed by reference).
+         * @param Translation_Entry $entry the entry to convert to po string.
          * @return string|false PO-style formatted string for the entry or
          *  false if the entry is empty
          */
-        public static function export_entry( &$entry ) {
+        public static function export_entry( $entry ) {
             if ( null === $entry->singular || '' === $entry->singular ) {
                 return false;